Fix flaky testMmapResourcesReleasedOnClose by using /proc/self/maps instead of filesystem free space#142516
Merged
ChrisHegarty merged 2 commits intoelastic:mainfrom Feb 16, 2026
Conversation
…rcesReleasedOnClose
ChrisHegarty
added
>test
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test verified that mmap'd
SharedBytesinstances release their mapped memory on close by measuring filesystem free space before and after 100 create/close iterations. This was inherently flaky becausegetUsableSpace()reflects the entire filesystem and is affected by concurrent activity from parallel test workers, OS indexing, and other processes.Replace the free-space assertion with a deterministic check of
/proc/self/mapson Linux, which directly inspects the process's memory-mapped regions for leaked entries. Restrict the test to Linux since that is where /proc/self/maps is available and where CI runs.The failing test is new. Introduced by #142460
closes #142488