Skip to content

Migrate third party module tests using legacy test clusters framework #140991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mamazzol merged 2 commits into from
Jan 21, 2026
Merged

Migrate third party module tests using legacy test clusters framework #140991

mamazzol merged 2 commits into from
Jan 21, 2026

Conversation

@mamazzol
Copy link
Contributor

@mamazzol mamazzol commented Jan 20, 2026

ES-11813

@mamazzol mamazzol requested a review from a team as a code owner January 20, 2026 17:50
@mamazzol mamazzol requested a review from a team January 20, 2026 17:51
@elasticsearchmachine elasticsearchmachine added v9.4.0 needs:triage Requires assignment of a team area label labels Jan 20, 2026
@mamazzol mamazzol added :Core/Infra/Core Core issues without another label Team:Core/Infra Meta label for core/infra team and removed needs:triage Requires assignment of a team area label v9.4.0 labels Jan 20, 2026
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 20, 2026

Pinging @elastic/es-core-infra (Team:Core/Infra)

@mamazzol mamazzol added >refactoring auto-backport Automatically create backport pull requests when merged branch:9.2 branch:9.1 branch:8.19 branch:9.3 >test Issues or PRs that are addressing/adding tests labels Jan 20, 2026
mosche
mosche approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@mosche mosche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor comments, LGTM given test pass 💪

...arty/src/main/java/org/elasticsearch/smoketest/AbstractWatcherThirdPartyYamlTestSuiteIT.java

for (String template : watcherTemplates) {
ClientYamlTestResponse templateExistsResponse = getAdminExecutionContext().callApi(
"indices.exists_index_template",
Copy link
Contributor

@mosche mosche Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason you switched to "indices.exists_template" here?

Copy link
Contributor Author

@mamazzol mamazzol Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once I swapped the cluster setup, the old "index.exists_template" returned 404. I found out it used a deprecated API so I tried switching to the one that was most close to it here

x-pack/qa/third-party/build.gradle
@@ -0,0 +1,8 @@
apply plugin: 'elasticsearch.java'
Copy link
Contributor

@mosche mosche Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes to this build file shouldn't be needed, right?

Copy link
Contributor Author

@mamazzol mamazzol Jan 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is necessary to have the Abstract centralised class that the other 3 tests use. I am not super expert on Gradle though so I am happy to make changes if you think it can be improved!

Copy link
Contributor

@mosche mosche Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, I see now. the more common approach would be to move the shared abstract class into a common module, e.g. transform/qa/common. In case we consolidate the rest tests under third-party in a next step it should be fine as is. Maybe a good time to check for the team's preferences in today's sync.

@mamazzol mamazzol merged commit e5f9637 into elastic:main Jan 21, 2026
35 checks passed
@elasticsearchmachine
Copy link
Collaborator

elasticsearchmachine commented Jan 21, 2026

💔 Backport failed

Status Branch Result
❌ 9.3 Commit could not be cherrypicked due to conflicts
❌ 9.1 Commit could not be cherrypicked due to conflicts
❌ 8.19 Commit could not be cherrypicked due to conflicts
❌ 9.2 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 140991

@mamazzol mamazzol deleted the migrate-third-party-tests branch January 21, 2026 16:21
@mamazzol mamazzol mentioned this pull request Jan 21, 2026
Merged
mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
21da65a 
…elastic#140991)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
This was referenced Jan 21, 2026
Merged
Merged
mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
5d307e2 
…elastic#140991)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
@mamazzol mamazzol mentioned this pull request Jan 21, 2026
Merged
@mamazzol
Copy link
Contributor Author

mamazzol commented Jan 21, 2026

💚 All backports created successfully

Status Branch Result
✅ 9.3
✅ 9.2
✅ 9.1
✅ 8.19

Questions ?

Please refer to the Backport tool documentation

mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
90293a0 
…elastic#140991)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
#	x-pack/qa/third-party/jira/build.gradle
mamazzol added a commit to mamazzol/elasticsearch that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
cf3bd2f 
…elastic#140991)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
elasticsearchmachine pushed a commit that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
dd79ce2 
…#140991) (#141061)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
elasticsearchmachine pushed a commit that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
e4d1bbd 
…#140991) (#141062)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
elasticsearchmachine pushed a commit that referenced this pull request Jan 21, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
cf13b14 
…#140991) (#141059)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 21, 2026
@szybia
Merge remote-tracking branch 'upstream/main' into reindex-cancel-yaml…
86c9e89 
…-tests

* upstream/main: (104 commits)
  Partition time-series source (elastic#140475)
  Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResultsWithSortManyFields elastic#141083
  Reindex relocation: skip nodes marked for shutdown (elastic#141044)
  Make fails on fixture caching not fail image building (elastic#140959)
  Add multi-project tests for get and list reindex (elastic#140980)
  Painless docs overhaul (reference) (elastic#137211)
  Panama vector implementation of codePointCount (elastic#140693)
  Enable PromQL in release builds (elastic#140808)
  Update rest-api-spec for Jina embedding task (elastic#140696)
  [CI] ShardSearchPhaseAPMMetricsTests testUniformCanMatchMetricAttributesWhenPlentyOfDocumentsInIndex failed (elastic#140848)
  Combine hash computation with bloom filter writes/reads (elastic#140969)
  Refactor posting iterators to provide more information (elastic#141058)
  Wait for cluster to recover to yellow before checking index health (elastic#141057) (elastic#141065)
  Fix repo analysis read count assertions (elastic#140994)
  Fixed a bug in logsdb rolling upgrade sereverless tests involving par… (elastic#141022)
  Fix readiness edge case on startup (elastic#140791)
  PromQL: fix quantile function (elastic#141033)
  ignore `mmr` command for check (in development) (elastic#140981)
  Use Double.compare to compare doubles in tdigest.Sort (elastic#141049)
  Migrate third party module tests using legacy test clusters framework (elastic#140991)
  ...
elasticsearchmachine pushed a commit that referenced this pull request Jan 22, 2026
@mamazzol
Migrate third party module tests using legacy test clusters framework (…
866599f 
…#140991) (#141064)

(cherry picked from commit e5f9637)

# Conflicts:
#	build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/RestrictedBuildApiService.java
#	x-pack/qa/third-party/jira/build.gradle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosche mosche mosche approved these changes

Assignees

No one assigned

Labels

auto-backport Automatically create backport pull requests when merged backport pending :Core/Infra/Core Core issues without another label >refactoring Team:Core/Infra Meta label for core/infra team >test Issues or PRs that are addressing/adding tests v8.19.11 v9.1.11 v9.2.5 v9.3.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mamazzol @elasticsearchmachine @mosche