Skip to content

Conversation

@markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Jan 20, 2026

Properly maps the mmr command for the license check tests.

Fixes error reported: #140941

@markjhoy markjhoy self-assigned this Jan 20, 2026
@markjhoy markjhoy added >non-issue Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch :Search Relevance/ES|QL Search functionality in ES|QL v9.4.0 labels Jan 20, 2026
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-relevance (Team:Search Relevance)

@markjhoy markjhoy enabled auto-merge (squash) January 20, 2026 16:55
@markjhoy markjhoy requested review from a team January 20, 2026 18:33
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it's necessary to ignore the classes, just to make sure the command to class translation is done correctly, either:

  • Change the MMR class name to Mmr (which I believe is the standard), or
  • Change in LicenseTests how the translation is done:
        Map<String, String> commandClassNameMapper = Map.of(
            "Where",
            "Filter",
            "Inline",
            "InlineStats",
            "Rrf",
            "RrfScoreEval",
            "Sort",
            "OrderBy",
            "Stats",
            "Aggregate",
            "Join",
            "LookupJoin",
            "Mmr",
            "MMR"
        );

Also, you need to unmute the test: c11b7dc

@markjhoy
Copy link
Contributor Author

markjhoy commented Jan 21, 2026

I don't think it's necessary to ignore the classes, just to make sure the command to class translation is done correctly, either:
Also, you need to unmute the test: c11b7dc

Thanks for this @carlosdelest - now I know ;) The latest commit should fix this. Also - re-running the test also created a doc snippet - is this correct behaviour?

@github-actions
Copy link
Contributor

ℹ️ Important: Docs version tagging

👋 Thanks for updating the docs! Just a friendly reminder that our docs are now cumulative. This means all 9.x versions are documented on the same page and published off of the main branch, instead of creating separate pages for each minor version.

We use applies_to tags to mark version-specific features and changes.

Expand for a quick overview

When to use applies_to tags:

✅ At the page level to indicate which products/deployments the content applies to (mandatory)
✅ When features change state (e.g. preview, ga) in a specific version
✅ When availability differs across deployments and environments

What NOT to do:

❌ Don't remove or replace information that applies to an older version
❌ Don't add new information that applies to a specific version without an applies_to tag
❌ Don't forget that applies_to tags can be used at the page, section, and inline level

🤔 Need help?

@markjhoy markjhoy requested a review from carlosdelest January 21, 2026 13:48
Copy link
Member

@carlosdelest carlosdelest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@markjhoy markjhoy changed the title [ES|QL] Ignore mmr Command for License Check (in development) [ES|QL] Properly map mmr Command for License Check Jan 21, 2026
@markjhoy markjhoy merged commit 1e27b4c into elastic:main Jan 21, 2026
35 checks passed
szybia added a commit to szybia/elasticsearch that referenced this pull request Jan 21, 2026
…-tests

* upstream/main: (104 commits)
  Partition time-series source (elastic#140475)
  Mute org.elasticsearch.xpack.esql.heap_attack.HeapAttackSubqueryIT testManyRandomKeywordFieldsInSubqueryIntermediateResultsWithSortManyFields elastic#141083
  Reindex relocation: skip nodes marked for shutdown (elastic#141044)
  Make fails on fixture caching not fail image building (elastic#140959)
  Add multi-project tests for get and list reindex (elastic#140980)
  Painless docs overhaul (reference) (elastic#137211)
  Panama vector implementation of codePointCount (elastic#140693)
  Enable PromQL in release builds (elastic#140808)
  Update rest-api-spec for Jina embedding task (elastic#140696)
  [CI] ShardSearchPhaseAPMMetricsTests testUniformCanMatchMetricAttributesWhenPlentyOfDocumentsInIndex failed (elastic#140848)
  Combine hash computation with bloom filter writes/reads (elastic#140969)
  Refactor posting iterators to provide more information (elastic#141058)
  Wait for cluster to recover to yellow before checking index health (elastic#141057) (elastic#141065)
  Fix repo analysis read count assertions (elastic#140994)
  Fixed a bug in logsdb rolling upgrade sereverless tests involving par… (elastic#141022)
  Fix readiness edge case on startup (elastic#140791)
  PromQL: fix quantile function (elastic#141033)
  ignore `mmr` command for check (in development) (elastic#140981)
  Use Double.compare to compare doubles in tdigest.Sort (elastic#141049)
  Migrate third party module tests using legacy test clusters framework (elastic#140991)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>non-issue :Search Relevance/ES|QL Search functionality in ES|QL Team:Search Relevance Meta label for the Search Relevance team in Elasticsearch v9.4.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants