Fixed text fields binary doc values breaking intake#140605
Merged
Kubik42 merged 1 commit intoelastic:mainfrom Jan 13, 2026
Merged
Fixed text fields binary doc values breaking intake#140605Kubik42 merged 1 commit intoelastic:mainfrom
Kubik42 merged 1 commit intoelastic:mainfrom
Conversation
Kubik42
added
>bug
>non-issue
Team:StorageEngine
:StorageEngine/Logs
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
martijnvg
approved these changes
Jan 13, 2026
| public static final IndexVersion STORE_FALLBACK_TEXT_FIELDS_IN_BINARY_DOC_VALUES = def(9_062_0_00, Version.LUCENE_10_3_2); | ||
| public static final IndexVersion STORE_FALLBACK_MOT_FIELDS_IN_BINARY_DOC_VALUES = def(9_063_0_00, Version.LUCENE_10_3_2); | ||
| public static final IndexVersion MOD_ROUTING_FUNCTION = def(9_064_0_00, Version.LUCENE_10_3_2); | ||
| public static final IndexVersion TEXT_FIELDS_BINARY_DOC_VALUES_TSDB_DOC_VALUES_FORMAT_CHECK = def(9_065_0_00, Version.LUCENE_10_3_2); |
Member
There was a problem hiding this comment.
maybe a shorter constant name? TEXT_FIELDS_BINARY_DOC_VALUES_FORMAT_CHECK?
spinscale
pushed a commit
to spinscale/elasticsearch
that referenced
this pull request
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #140471 we changed how fallback text fields are stored. At the time we got luck (unlucky?) and the CI passed. However, the intake is now breaking.
The reason for the failure is that prior to #140471 , we stored fallback text fields exclusively in binary doc values. But with #140471 , we're now switching between binary doc values and stored fields depending on whether the time series doc values format is enabled.
This PR addresses that.