Skip to content

Use stored fallback fields when time series doc values format is not used#140471

Merged
Kubik42 merged 1 commit intoelastic:mainfrom
Kubik42:text-fields-binary-doc-values-time-series-format
Jan 13, 2026
Merged

Use stored fallback fields when time series doc values format is not used#140471
Kubik42 merged 1 commit intoelastic:mainfrom
Kubik42:text-fields-binary-doc-values-time-series-format

Conversation

@Kubik42
Copy link
Contributor

@Kubik42 Kubik42 commented Jan 9, 2026

We only want to use fallback binary doc values when time series format is enabled, otherwise storing values in a StoredField is more efficient.

This PR reintroduces using StoredFields for fallback text fields based on the value of useBinaryDocValues.

@Kubik42 Kubik42 force-pushed the text-fields-binary-doc-values-time-series-format branch 6 times, most recently from 3a0409e to 0e2bf57 Compare January 12, 2026 22:28
@Kubik42 Kubik42 force-pushed the text-fields-binary-doc-values-time-series-format branch from 0e2bf57 to 9894a9d Compare January 12, 2026 22:29
@Kubik42 Kubik42 marked this pull request as ready for review January 12, 2026 22:50
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kubik42 Kubik42 merged commit c4595ca into elastic:main Jan 13, 2026
35 checks passed
@Kubik42 Kubik42 deleted the text-fields-binary-doc-values-time-series-format branch January 13, 2026 16:28
eranweiss-elastic pushed a commit to eranweiss-elastic/elasticsearch that referenced this pull request Jan 15, 2026
spinscale pushed a commit to spinscale/elasticsearch that referenced this pull request Jan 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments