ES|QL: Enable CCS tests for FORK#139302
Merged
ioanatia merged 4 commits intoelastic:mainfrom Dec 11, 2025
Merged
Conversation
ioanatia
added
>test
ioanatia
commented
Dec 11, 2025
| required_capability: subquery_in_from_command | ||
|
|
||
| FROM employees, (FROM sample_data | ||
| FROM employees, (FROM sample_data metadata _index |
Contributor
Author
There was a problem hiding this comment.
https://github.com/elastic/elasticsearch/pull/137776/files#diff-ce2360e7ca89b74f2454822d45cbadf8d4218f97777df7d160a0863053a041fc for all subqueries tests we removed the fork_v9 capability and we pushed the metadata _index in the subqueries.
this means this test was not enabled for CCS, and once we enabled the FORK tests, this test was failing because the _index metadata column contained values that had the remote index tag:
Actual: |
-- | --
_index:keyword \| emp_no:integer \| languages:integer \| cnt:long \| ts:datetime |
remote_cluster:employees \| 10091 \| 3 \| null \| null |
remote_cluster:employees \| 10092 \| 1 \| null \| null |
remote_cluster:employees \| 10093 \| 3 \| null \| null |
null \| null \| null \| 2 \| 2023-10-23T12:00:00.000Z |
null \| null \| null \| 5 \| 2023-10-23T13:00:00.000Z |
|
Expected: |
_index:keyword \| emp_no:integer \| languages:integer \| cnt:long \| ts:datetime |
employees \| 10091 \| 3 \| null \| null |
employees \| 10092 \| 1 \| null \| null |
employees \| 10093 \| 3 \| null \| null |
null \| null \| null \| 2 \| 2023-10-23T12:00:00.000Z |
null \| null \| null \| 5 \| 2023-10-23T13:00:00.000Z
I think that during #137776 we just missed this test, so these changes here should be safe to make.
elasticsearchmachine
added
Team:Search Relevance
Collaborator
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
carlosdelest
approved these changes
Dec 11, 2025
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Dec 11, 2025
* upstream/main: (79 commits)
Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/140_pre_filter_search_shards/prefilter on non-indexed date fields} elastic#139381
Adjust error bounds for bfloat16 value checks (elastic#139371)
Unmute some vector CSS tests (elastic#139370)
Do not allow `project_routing` as a query param (elastic#139206)
Unmute HalfFloat...Tests#testSynthesizeArrayRandom (elastic#139341)
Remove leniency in LinkedProjectConfig builder methods (elastic#139012)
EQL: fix project_routing (elastic#139366)
Add patch version for 9.2 index version constant (elastic#139362)
Mute org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT test {p0=search.vectors/200_dense_vector_docvalue_fields/dense_vector docvalues with bfloat16} elastic#139368
ES|QL: Enable CCS tests for FORK (elastic#139302)
Restructuring the semantic_text field type page (elastic#138571)
AggregateMetricDouble fields should not build BKD indexes (elastic#138724)
Feature/count by trunc with filter (elastic#138765)
ESQL: Convert TS 500 error to 400 (elastic#139360)
[CI] Rerun failing tests for periodic build pipelines (elastic#139200)
revert muting saml test (elastic#139327)
Add TDigest histogram as metric (elastic#139247)
Links solved bugs to class cast exception changelog and unmutes errors (elastic#139340)
Ensure integer sorts are rewritten to long sorts for BWC indexes (elastic#139293)
Integrate stored fields format bloom filter with synthetic _id (elastic#138515)
...
This was referenced Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
given the fix in #138332 - we should be able to re-enable the test for CCS again for FORK.
since the fix from #138332 is only available in snapshot, these CCS tests using FORK are also only enabled when using snapshot builds.