Do not allow project_routing as a query param#139206
Merged
pawankartik-elastic merged 8 commits intoelastic:mainfrom Dec 11, 2025
Merged
Do not allow project_routing as a query param#139206pawankartik-elastic merged 8 commits intoelastic:mainfrom
project_routing as a query param#139206pawankartik-elastic merged 8 commits intoelastic:mainfrom
Conversation
elasticsearchmachine
added
v9.3.0
serverless-linked
pawankartik-elastic
added
>refactoring
Team:Search Foundations
Collaborator
|
Pinging @elastic/es-search-foundations (Team:Search Foundations) |
server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestResolveIndexAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestResolveIndexAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/rest/action/admin/indices/RestResolveIndexAction.java
Outdated
Show resolved
Hide resolved
quux00
approved these changes
Dec 10, 2025
Contributor
quux00
left a comment
quux00
left a comment
There was a problem hiding this comment.
LGTM.
Don't forget that we also need to update the specs in elasticsearch-specification as a follow-on PR.
szybia
added a commit
to szybia/elasticsearch
that referenced
this pull request
Dec 11, 2025
* upstream/main: (79 commits)
Mute org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT test {p0=search/140_pre_filter_search_shards/prefilter on non-indexed date fields} elastic#139381
Adjust error bounds for bfloat16 value checks (elastic#139371)
Unmute some vector CSS tests (elastic#139370)
Do not allow `project_routing` as a query param (elastic#139206)
Unmute HalfFloat...Tests#testSynthesizeArrayRandom (elastic#139341)
Remove leniency in LinkedProjectConfig builder methods (elastic#139012)
EQL: fix project_routing (elastic#139366)
Add patch version for 9.2 index version constant (elastic#139362)
Mute org.elasticsearch.test.rest.yaml.RcsCcsCommonYamlTestSuiteIT test {p0=search.vectors/200_dense_vector_docvalue_fields/dense_vector docvalues with bfloat16} elastic#139368
ES|QL: Enable CCS tests for FORK (elastic#139302)
Restructuring the semantic_text field type page (elastic#138571)
AggregateMetricDouble fields should not build BKD indexes (elastic#138724)
Feature/count by trunc with filter (elastic#138765)
ESQL: Convert TS 500 error to 400 (elastic#139360)
[CI] Rerun failing tests for periodic build pipelines (elastic#139200)
revert muting saml test (elastic#139327)
Add TDigest histogram as metric (elastic#139247)
Links solved bugs to class cast exception changelog and unmutes errors (elastic#139340)
Ensure integer sorts are rewritten to long sorts for BWC indexes (elastic#139293)
Integrate stored fields format bloom filter with synthetic _id (elastic#138515)
...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ES-13725: We previously had plans to allow
project_routingas a query param and also in the request body. However, after the recent discussions with Kibana and the clients team, we will now restrict it to the request body.Note:
_msearchand_msearch/templateendpoints._resolve/indexdoes not have aPOSTroute. For that reason, I'm leaving it untouched. We either make a similar exception for it, or, add a newRoute.Route.