Merge old rate implementation to new implementation#134603
Merged
dnhatn merged 1 commit intoelastic:mainfrom Sep 12, 2025
Merged
Merge old rate implementation to new implementation#134603dnhatn merged 1 commit intoelastic:mainfrom
dnhatn merged 1 commit intoelastic:mainfrom
Conversation
dnhatn
changed the title
kkrik-es
approved these changes
Sep 12, 2025
Member
Author
|
Thanks Kostas! |
Collaborator
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
This was referenced Sep 12, 2025
gmjehovich
pushed a commit
to gmjehovich/elasticsearch
that referenced
this pull request
Sep 18, 2025
This change merges the old rate implementation into the new one, allowing us to apply optimizations in follow-up PRs. It also fixes issues between the old and new implementations introduced in the previous PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change merges the old rate implementation into the new one, allowing us to apply optimizations in follow-up PRs. It also fixes issues between the old and new implementations introduced in the previous PR.
There are errors in the current rate calculation, but I will address them in subsequent PRs to preserve existing behavior for now.