Skip to content

fix: enable date_detection for all apm data streams #130466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 8, 2025
Merged

fix: enable date_detection for all apm data streams #130466

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4d8f973
Update [email protected]
kruskall Jul 2, 2025
3cd0c16
Update resources.yaml
kruskall Jul 2, 2025
72a351e
fix: explicitly map system.process.cpu.start_time to date
kruskall Jul 2, 2025
5cc6e2f
Update [email protected]
kruskall Jul 2, 2025
6269582
Update [email protected]
kruskall Jul 2, 2025
3c5f315
Update [email protected]
kruskall Jul 2, 2025
8a3049b
Merge branch 'main' into kruskall-patch-1
kruskall Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions x-pack/plugin/apm-data/src/main/resources/component-templates/[email protected]
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ _meta:
managed: true
template:
mappings:
date_detection: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want this to be true? The original removal in https://github.com/elastic/elasticsearch/pull/128913/files was under the assumption that the default is true.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for the record, the idea is to disable date detection for everything and explicitly enabled it for specific fields

dynamic: true
dynamic_templates:
- numeric_labels:
Expand All @@ -12,6 +13,8 @@ template:
type: scaled_float
scaling_factor: 1000000
properties:
system.process.cpu.start_time:
type: date
data_stream.dataset:
type: constant_keyword
data_stream.namespace:
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/apm-data/src/main/resources/resources.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# "version" holds the version of the templates and ingest pipelines installed
# by xpack-plugin apm-data. This must be increased whenever an existing template or
# pipeline is changed, in order for it to be updated on Elasticsearch upgrade.
version: 16
version: 17

component-templates:
# Data lifecycle.
Expand Down