fix: enable date_detection for all apm data streams #130466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v9.2.0
needs:triage
kruskall
added
>feature
:Data Management/Data streams
|
Pinging @elastic/es-data-management (Team:Data Management) |
rubvs
reviewed
Jul 2, 2025
| managed: true | ||
| template: | ||
| mappings: | ||
| date_detection: false |
There was a problem hiding this comment.
Don't we want this to be true? The original removal in https://github.com/elastic/elasticsearch/pull/128913/files was under the assumption that the default is true.
There was a problem hiding this comment.
for the record, the idea is to disable date detection for everything and explicitly enabled it for specific fields
simitt
reviewed
Jul 2, 2025
x-pack/plugin/apm-data/src/main/resources/component-templates/[email protected]
Outdated
Show resolved
Hide resolved
rubvs
approved these changes
Jul 4, 2025
This was referenced Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert #128913 and flip the setting to actually fix the issue
enable date_detection for all apm data streams
after some discussion in elastic/apm-server#16064 it was decided to reenable date_detection everywhere and treat any issue as a bug
Closes elastic/apm-server#16064