[ES|QL] Fix mapping for the colors CSV dataset (failing bwc tests)#130090
Merged
afoucret merged 4 commits intoelastic:mainfrom Jun 26, 2025
Merged
[ES|QL] Fix mapping for the colors CSV dataset (failing bwc tests)#130090afoucret merged 4 commits intoelastic:mainfrom
afoucret merged 4 commits intoelastic:mainfrom
Conversation
afoucret
added
>test
elasticsearchmachine
added
Team:Analytics
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
alex-spies
requested changes
Jun 26, 2025
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
The mapping fix looks okay, thank you!
...l/src/main/java/org/elasticsearch/xpack/esql/inference/embedding/DenseEmbeddingOperator.java
Outdated
Show resolved
Hide resolved
Contributor
|
Also note that, this can't fix #128224. That was on 8.19. I have not seen similar issues with the |
alex-spies
reviewed
Jun 26, 2025
afoucret
commented
Jun 26, 2025
| "type": "dense_vector", | ||
| "similarity": "l2_norm" | ||
| "similarity": "l2_norm", | ||
| "index_options": { |
Contributor
Author
There was a problem hiding this comment.
ℹ️ @alex-spies It seems that adding explicit index_options is preventing the failure
alex-spies
approved these changes
Jun 26, 2025
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
Great, thanks @afoucret !
alex-spies
added
the
auto-backport
Collaborator
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
afoucret
added a commit
to afoucret/elasticsearch
that referenced
this pull request
Jun 27, 2025
…ng bwc tests) (elastic#130090) (cherry picked from commit e2dfd5d) # Conflicts: # muted-tests.yml
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
smalyshev
pushed a commit
to smalyshev/elasticsearch
that referenced
this pull request
Jun 27, 2025
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #130085