ESQL: Mute only dense vector tests#130089
Closed
alex-spies wants to merge 1 commit intoelastic:mainfrom
Closed
Conversation
alex-spies
added
>test
Collaborator
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
elasticsearchmachine
added
the
Team:Analytics
craigtaverner
approved these changes
Jun 26, 2025
Contributor
craigtaverner
left a comment
craigtaverner
left a comment
There was a problem hiding this comment.
Muting just dense_vector seems much better than muting the entire test class.
ivancea
approved these changes
Jun 26, 2025
alex-spies
added
auto-merge-without-approval
alex-spies
removed
the
auto-merge-without-approval
Contributor
Author
Contributor
|
Quick drive-by note: sidestepping a bug isn’t quite the same as fixing it. Let’s make sure we leave the issue with a proper reproduction next time, this one’s a real bug: #130540 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #130085
The
dense_vectordataset started acting up in 9.1->9.0 bwc tests. Let's skip the corresponding dataset whose index failed to be created in the tests.