ESQL: use field_caps native nested fields filtering#121645
Merged
astefan merged 1 commit intoelastic:8.17from Feb 4, 2025
Merged
ESQL: use field_caps native nested fields filtering#121645astefan merged 1 commit intoelastic:8.17from
astefan merged 1 commit intoelastic:8.17from
Conversation
…7201) (elastic#117375) * ESQL: use field_caps native nested fields filtering (elastic#117201) * Just filter the nested fields natively with field_caps support
astefan
added
>bug
backport
auto-merge-without-approval
alex-spies
approved these changes
Feb 4, 2025
Contributor
alex-spies
left a comment
alex-spies
left a comment
There was a problem hiding this comment.
It seems this is an identical backport of #117201 except for 1 line (commas in the EsqlCapabilities enum). It adds a capability, but no transport version bump. Therefore, I think this should be fine to backport.
We could be extra paranoid and slap test-full-bwc on this, but since the backport to 8.x didn't cause trouble, full bwc tests for 8.17 shouldn't cause trouble, either.
astefan
added a commit
to astefan/elasticsearch
that referenced
this pull request
Feb 6, 2025
…7201) (elastic#117375) (elastic#121645) * Just filter the nested fields natively with field_caps support (cherry picked from commit 73381db)
astefan
added a commit
that referenced
this pull request
Feb 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #117054 by partially reverting #111495 and using -nested as a filter for the _field_caps call.
Backports #117201.