Skip to content

[TEST] Ensure that feature flag is enabled in new KeywordFieldMapperTests #121248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elasticsearchmachine merged 2 commits into from
Jan 30, 2025
Merged

[TEST] Ensure that feature flag is enabled in new KeywordFieldMapperTests #121248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cce587d
Ensure that feature flag is enabled in new KeywordFieldMapperTests
lkts Jan 29, 2025
0cac475
Merge branch 'main' into fix_keyword_tests
lkts Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions muted-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,12 +319,6 @@ tests:
- class: org.elasticsearch.xpack.security.CoreWithSecurityClientYamlTestSuiteIT
method: test {yaml=cat.aliases/10_basic/Simple alias}
issue: https://github.com/elastic/elasticsearch/issues/121186
- class: org.elasticsearch.index.mapper.KeywordFieldMapperTests
method: testFieldTypeWithSkipDocValues_LogsDbMode
issue: https://github.com/elastic/elasticsearch/issues/121232
- class: org.elasticsearch.index.mapper.KeywordFieldMapperTests
method: testFieldTypeDefault_ConfiguredDocValues
issue: https://github.com/elastic/elasticsearch/issues/121233
- class: org.elasticsearch.xpack.ml.integration.ClassificationIT
method: testWithDatastreams
issue: https://github.com/elastic/elasticsearch/issues/121236
Expand Down
16 changes: 16 additions & 0 deletions server/src/test/java/org/elasticsearch/index/mapper/KeywordFieldMapperTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -773,6 +773,8 @@ public void testDocValuesLoadedFromStoredSynthetic() throws IOException {
}

public void testFieldTypeWithSkipDocValues_LogsDbMode() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name())
Expand All @@ -792,6 +794,8 @@ public void testFieldTypeWithSkipDocValues_LogsDbMode() throws IOException {
}

public void testFieldTypeDefault_StandardMode() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.STANDARD.name())
Expand All @@ -811,6 +815,8 @@ public void testFieldTypeDefault_StandardMode() throws IOException {
}

public void testFieldTypeDefault_NonMatchingFieldName() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name())
Expand All @@ -830,6 +836,8 @@ public void testFieldTypeDefault_NonMatchingFieldName() throws IOException {
}

public void testFieldTypeDefault_ConfiguredIndexed() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name())
Expand All @@ -850,6 +858,8 @@ public void testFieldTypeDefault_ConfiguredIndexed() throws IOException {
}

public void testFieldTypeDefault_ConfiguredDocValues() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name())
Expand All @@ -870,6 +880,8 @@ public void testFieldTypeDefault_ConfiguredDocValues() throws IOException {
}

public void testFieldTypeDefault_LogsDbMode_NonSortField() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder().put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name()).build(),
mapping(b -> {
Expand All @@ -886,6 +898,8 @@ public void testFieldTypeDefault_LogsDbMode_NonSortField() throws IOException {
}

public void testFieldTypeWithSkipDocValues_IndexedFalseDocValuesTrue() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name())
Expand All @@ -907,6 +921,8 @@ public void testFieldTypeWithSkipDocValues_IndexedFalseDocValuesTrue() throws IO
}

public void testFieldTypeDefault_IndexedFalseDocValuesFalse() throws IOException {
assumeTrue("Needs feature flag to be enabled", FieldMapper.DOC_VALUES_SPARSE_INDEX.isEnabled());

final MapperService mapperService = createMapperService(
Settings.builder()
.put(IndexSettings.MODE.getKey(), IndexMode.LOGSDB.name())
Expand Down