Skip to content

Comments

[TEST] Ensure that feature flag is enabled in new KeywordFieldMapperTests#121248

Merged
elasticsearchmachine merged 2 commits intoelastic:mainfrom
lkts:fix_keyword_tests
Jan 30, 2025
Merged

[TEST] Ensure that feature flag is enabled in new KeywordFieldMapperTests#121248
elasticsearchmachine merged 2 commits intoelastic:mainfrom
lkts:fix_keyword_tests

Conversation

@lkts
Copy link
Contributor

@lkts lkts commented Jan 29, 2025

DOC_VALUES_SPARSE_INDEX is needed for tests to work.

@lkts lkts added >test Issues or PRs that are addressing/adding tests auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport Automatically create backport pull requests when merged :StorageEngine/Logs You know, for Logs v8.18.0 labels Jan 29, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts
Copy link
Contributor Author

lkts commented Jan 29, 2025

Closes #121233.
Closes #121232.

@elasticsearchmachine elasticsearchmachine merged commit 10aec78 into elastic:main Jan 30, 2025
16 checks passed
@lkts lkts deleted the fix_keyword_tests branch January 30, 2025 00:20
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.x Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 121248

@lkts
Copy link
Contributor Author

lkts commented Jan 30, 2025

#120741 is not backported so i can't backport this

@martijnvg
Copy link
Member

#120741 is not backported so i can't backport this

That is because docvalues skippers is a Lucene 10 feature and 8.x is and will remain on Lucene 9.

@lkts lkts removed backport pending auto-backport Automatically create backport pull requests when merged v8.18.0 labels Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :StorageEngine/Logs You know, for Logs Team:StorageEngine >test Issues or PRs that are addressing/adding tests v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants