[ML] Adds a new field supported_task_types in the configuration response#120150
Conversation
|
Hi @jonathan-buttner, I've created a changelog YAML for you. |
…er/elasticsearch into ml-services-api-task-type
…er/elasticsearch into ml-services-api-task-type
|
Pinging @elastic/ml-core (Team:ML) |
ymao1
left a comment
There was a problem hiding this comment.
LGTM. Works as described. Left one optional nit.
I'm guessing there will be a followup to add the task type specific fields?
| configurationMap.put( | ||
| RESOURCE_NAME, | ||
| new SettingsConfiguration.Builder().setDescription("The name of your Azure OpenAI resource.") | ||
| new SettingsConfiguration.Builder(EnumSet.of(TaskType.TEXT_EMBEDDING, TaskType.COMPLETION)).setDescription( |
There was a problem hiding this comment.
nit: would it make sense to use the supportedTaskTypes defined above for the configurations that support all supported task types and just explicitly define it for the configurations that don't support all of them?
There was a problem hiding this comment.
Yeah, I'll make that change 👍
|
Thanks @ymao1 !
Yep that's correct. I still need to do that. I was going to do it in a separate PR. |
💚 Backport successful
|
…nse (elastic#120150) * Adding new field to settings class * adding new available_for_task_types field * Update docs/changelog/120150.yaml * Delete docs/changelog/120150.yaml * Fixing tests and task types * Renaming field to supported_task_types * Pulling in chat_completion addition * Addressing feedback
…nse (#120150) (#120410) * Adding new field to settings class * adding new available_for_task_types field * Update docs/changelog/120150.yaml * Delete docs/changelog/120150.yaml * Fixing tests and task types * Renaming field to supported_task_types * Pulling in chat_completion addition * Addressing feedback
This PR adds a new field for the service configuration response to indicate which task types are supported by a field.
New field:
supported_task_typesThis field will be included in the response for each field returned.
Dependent on this PR being merged first: #119982Example