[ML] Adding new chat_completion task type for unified API #119982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-buttner
added
:ml
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
davidkyle
approved these changes
Jan 13, 2025
Collaborator
💔 Backport failed
You can use sqren/backport to manually backport by running |
Contributor
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
jonathan-buttner
added a commit
to jonathan-buttner/elasticsearch
that referenced
this pull request
Jan 15, 2025
…9982) * Creating new chat completion task type * Adding some comments * Refactoring names and removing todo * Exposing chat completion for openai and eis for now * Fixing tests (cherry picked from commit f9a3721) # Conflicts: # muted-tests.yml # x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/Utils.java
jonathan-buttner
added a commit
that referenced
this pull request
Jan 16, 2025
) (#120224) * [ML] Adding new chat_completion task type for unified API (#119982) * Creating new chat completion task type * Adding some comments * Refactoring names and removing todo * Exposing chat completion for openai and eis for now * Fixing tests (cherry picked from commit f9a3721) # Conflicts: # muted-tests.yml # x-pack/plugin/inference/qa/inference-service-tests/src/javaRestTest/java/org/elasticsearch/xpack/inference/InferenceCrudIT.java # x-pack/plugin/inference/src/test/java/org/elasticsearch/xpack/inference/Utils.java * Fixing addFirst * Fixing test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new task type
chat_completionwhich is specifically used for OpenAI and the ElasticInferenceService for the new unified API.I also fixed a test that was muted by reworking the
InferenceCRUDITtests.Fixes: #119959