Skip to content

Optimized index sorting for OTel logs #119504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
felixbarny merged 5 commits into from
Jan 8, 2025
Merged

Optimized index sorting for OTel logs #119504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
36c597d
Optimized index sorting for OTel logs
felixbarny Jan 3, 2025
0396db9
Update docs/changelog/119504.yaml
felixbarny Jan 3, 2025
8c843f8
Remove sort.mode and sort.missing to fix LogsIndexModeEnabledRestTest…
felixbarny Jan 3, 2025
f798b23
Sort host name asc
felixbarny Jan 7, 2025
c5fb154
Merge branch 'main' into otel-logs-optimized-sorting
felixbarny Jan 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/119504.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 119504
summary: Optimized index sorting for OTel logs
area: Data streams
type: enhancement
Copy link
Member

@martijnvg martijnvg Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this is a bug?

Copy link
Member Author

@felixbarny felixbarny Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't think of this as a bug. Is it because we're sorting the timestamp in ascending order right now? What's the consequence of that from a user's perspective?

Copy link
Member

@martijnvg martijnvg Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe certain queries that filter on timestamp will now slightly perform better. But that isn't a really a bug, so let's leave this as an enhancement.

issues: []
1 change: 1 addition & 0 deletions x-pack/plugin/otel-data/src/main/resources/component-templates/logs-otel@mappings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ template:
mode: logsdb
sort:
field: [ "resource.attributes.host.name", "@timestamp" ]
order: [ "asc", "desc" ]
mappings:
properties:
attributes:
Expand Down