Optimized index sorting for OTel logs#119504
Merged
felixbarny merged 5 commits intoelastic:mainfrom Jan 8, 2025
Merged
Conversation
felixbarny
added
>enhancement
:StorageEngine/Data streams
elasticsearchmachine
added
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @felixbarny, I've created a changelog YAML for you. |
kkrik-es
reviewed
Jan 3, 2025
x-pack/plugin/otel-data/src/main/resources/component-templates/logs-otel@mappings.yaml
Outdated
Show resolved
Hide resolved
…IT.testLogsAtSettingWithTimeSeriesOverride I don't really get why you would want to set index.mode: time_series in logs@custom but these sort settings aren't compatible with tsdb
martijnvg
approved these changes
Jan 7, 2025
Member
martijnvg
left a comment
martijnvg
left a comment
There was a problem hiding this comment.
Minor comment LGTM otherwise.
x-pack/plugin/otel-data/src/main/resources/component-templates/logs-otel@mappings.yaml
Outdated
Show resolved
Hide resolved
| pr: 119504 | ||
| summary: Optimized index sorting for OTel logs | ||
| area: Data streams | ||
| type: enhancement |
Member
Author
There was a problem hiding this comment.
Oh, I didn't think of this as a bug. Is it because we're sorting the timestamp in ascending order right now? What's the consequence of that from a user's perspective?
Member
There was a problem hiding this comment.
Maybe certain queries that filter on timestamp will now slightly perform better. But that isn't a really a bug, so let's leave this as an enhancement.
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Jan 8, 2025
felixbarny
added a commit
to felixbarny/elasticsearch
that referenced
this pull request
Jan 8, 2025
(cherry picked from commit afda404)
Member
Author
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jan 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://github.com/elastic/elasticsearch/pull/118968/files/680a023e3fefe0d79affdcc81a0f7e146b1c847e#r1899527289