Revert "Index stats enhancement: creation date and tier_preference (#116339)"#116959
Merged
DaveCTurner merged 2 commits intoelastic:mainfrom Nov 18, 2024
Merged
Revert "Index stats enhancement: creation date and tier_preference (#116339)"#116959DaveCTurner merged 2 commits intoelastic:mainfrom
DaveCTurner merged 2 commits intoelastic:mainfrom
Conversation
…lastic#116339)" This reverts commit e0af123.
DaveCTurner
added
>non-issue
:Core/Infra/Stats
elasticsearchmachine
added
the
Team:Data Management (obsolete)
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
DaveCTurner
commented
Nov 18, 2024
Comment on lines
-240
to
-245
| if (indexStats.getTierPreference() != null) { | ||
| builder.field("tier_preference", indexStats.getTierPreference()); | ||
| } | ||
| if (indexStats.getCreationDate() != null) { | ||
| builder.field("creation_date", indexStats.getCreationDate()); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I believe this is ok, I don't think any clients could have been expecting these fields yet and they were optional anyway so we can remove them without ceremony.
dakrone
approved these changes
Nov 18, 2024
Member
dakrone
left a comment
dakrone
left a comment
There was a problem hiding this comment.
LGTM, how will we eventually be able to remove the serialization?
Comment on lines
+193
to
+194
| out.writeMap(Map.of(), StreamOutput::writeStringCollection); | ||
| out.writeMap(Map.of(), StreamOutput::writeLong); |
Member
There was a problem hiding this comment.
Should we add some kind of check to be able to eventually remove these?
Contributor
Author
There was a problem hiding this comment.
Yeah eventually all these transport versions get collapsed into a release-version-named one (see e.g. org.elasticsearch.TransportVersions#V_8_15_2) and then this branch will be dead code:
if (in.getTransportVersion().onOrAfter(TransportVersions.V_8_16_x)) {
indexHealthMap = in.readMap(ClusterHealthStatus::readFrom);
indexStateMap = in.readMap(IndexMetadata.State::readFrom);
} else if (in.getTransportVersion().onOrAfter(TransportVersions.V_8_16_x)) {
// same condition as the previous if so cannot get here
thecoop
approved these changes
Nov 18, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
…lastic#116339)" (elastic#116959) This reverts commit e0af123.
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…lastic#116339)" (elastic#116959) This reverts commit e0af123.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit e0af123.