Index stats enhancement: creation date and tier_preference#116339
Merged
3kt merged 29 commits intoelastic:mainfrom Nov 15, 2024
Merged
Index stats enhancement: creation date and tier_preference#1163393kt merged 29 commits intoelastic:mainfrom
3kt merged 29 commits intoelastic:mainfrom
Conversation
8efa052 to
2d471ce
Compare
5 tasks
0ef0ec8 to
e6113ef
Compare
2a51af2 to
6326bba
Compare
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
Collaborator
|
Hi @3kt, I've created a changelog YAML for you. |
3kt
added a commit
to 3kt/elasticsearch
that referenced
this pull request
Nov 15, 2024
…16339) * Expose tier preference as part of the index stats * Also expose index creation date in index stats * Added test
Contributor
|
I went to revert this, but it involves a TransportVersion change, so it's not quite as trivial as hitting revert and merging the resulting PR, so I'm ignoring this for now. I imagine @elastic/es-data-management will discuss again on Monday and figure out a way forward. |
Contributor
Author
|
What's the matter @joegallo ? Are there implications I didn't foresee? |
8 tasks
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Nov 18, 2024
…16339) * Expose tier preference as part of the index stats * Also expose index creation date in index stats * Added test
Member
|
@3kt yes, we discussed this as a Data Management team, and decided we didn't want to pursue this (and not in this format also). I'm sorry, I hadn't had a chance to comment that yet on the PR before it was reviewed. |
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 18, 2024
…lastic#116339)" This reverts commit e0af123.
DaveCTurner
pushed a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Nov 18, 2024
This change was reverted with a new transport protocol in `main` so we must backport the new protocol versions to `8.x`.
DaveCTurner
added a commit
that referenced
this pull request
Nov 18, 2024
DaveCTurner
added a commit
that referenced
this pull request
Nov 18, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Nov 20, 2024
…lastic#116339)" (elastic#116959) This reverts commit e0af123.
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…16339) * Expose tier preference as part of the index stats * Also expose index creation date in index stats * Added test
alexey-ivanov-es
pushed a commit
to alexey-ivanov-es/elasticsearch
that referenced
this pull request
Nov 28, 2024
…lastic#116339)" (elastic#116959) This reverts commit e0af123.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This adds two additional fields to the index stats API call response:
creation_datetier_preferenceBoth information are transparently pushed from the
IndexMetadataclass, otherwise natively displayed in the index settings.A stats call against an index would give such a response:
This is similar to #81954
Why
In their current state, the index stats are hard to consume for users, as most exposed stats are increasing counters. Giving contextual information such as when the index was created or what data tier it currently lives in allows users to answer questions like: