[Test] Increase timeout of waiting for indexing operations#112908
Merged
elasticsearchmachine merged 3 commits intoelastic:mainfrom Sep 17, 2024
Merged
[Test] Increase timeout of waiting for indexing operations#112908elasticsearchmachine merged 3 commits intoelastic:mainfrom
elasticsearchmachine merged 3 commits intoelastic:mainfrom
Conversation
Larger number of indexing operations can take a while to complete on slower machines for which we need to wait for longer. Relates: elastic#111957 Resolves: elastic#112423
ywangd
added
>test
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
ywangd
commented
Sep 16, 2024
Comment on lines
-1867
to
+1875
| safeAwait(inFlightAsyncOperations.remove(waitFor)); | ||
| try { | ||
| assertTrue( | ||
| "operation did not complete within timeout", | ||
| inFlightAsyncOperations.remove(waitFor).await(60, TimeUnit.SECONDS) | ||
| ); | ||
| } catch (InterruptedException e) { | ||
| Thread.currentThread().interrupt(); | ||
| fail(e, "interrupted while waiting for operation to complete"); | ||
| } |
Member
Author
There was a problem hiding this comment.
Alternatively, we could limit the number of operations. I think most usages are just a few indexing requests. But decided to keep the change minimal which is a middle ground between the previous code (wait indefinitely) and the current code.
DaveCTurner
approved these changes
Sep 16, 2024
Contributor
DaveCTurner
left a comment
DaveCTurner
left a comment
There was a problem hiding this comment.
Bleurgh we should really not have such slow tests here. I am planning to revisit this area at some point to clean up the waiting mechanism, this'll do for now.
ywangd
added
auto-merge-without-approval
idegtiarenko
approved these changes
Sep 16, 2024
Member
Author
|
@elasticmachine update branch |
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Sep 17, 2024
…12908) Larger number of indexing operations can take a while to complete on slower machines for which we need to wait for longer. Relates: elastic#111957 Resolves: elastic#112423
Collaborator
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Larger number of indexing operations can take a while to complete on slower machines for which we need to wait for longer.
Relates: #111957
Resolves: #112423