Improve interrupt handling in tests#111957
Merged
DaveCTurner merged 2 commits intoelastic:mainfrom Aug 20, 2024
Merged
Conversation
The test utilities `waitUntil()`, `indexRandom()`, `startInParallel()` and `runInParallel()` all declare `InterruptedException` amongst the checked exceptions they throw, but in practice there's nothing useful to do with such an exception except to fail the test. With this change we handle the interrupt within the utility methods instead, avoiding exception-handling noise in callers.
DaveCTurner
added
>test
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
lkts
pushed a commit
to lkts/elasticsearch
that referenced
this pull request
Aug 20, 2024
The test utilities `waitUntil()`, `indexRandom()`, `startInParallel()` and `runInParallel()` all declare `InterruptedException` amongst the checked exceptions they throw, but in practice there's nothing useful to do with such an exception except to fail the test. With this change we handle the interrupt within the utility methods instead, avoiding exception-handling noise in callers.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 23, 2024
Following elastic#111957 these methods no longer throw an `InterruptedException.
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Aug 27, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 27, 2024
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
Aug 27, 2024
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
The test utilities `waitUntil()`, `indexRandom()`, `startInParallel()` and `runInParallel()` all declare `InterruptedException` amongst the checked exceptions they throw, but in practice there's nothing useful to do with such an exception except to fail the test. With this change we handle the interrupt within the utility methods instead, avoiding exception-handling noise in callers.
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
davidkyle
pushed a commit
to davidkyle/elasticsearch
that referenced
this pull request
Sep 5, 2024
The test utilities `waitUntil()`, `indexRandom()`, `startInParallel()` and `runInParallel()` all declare `InterruptedException` amongst the checked exceptions they throw, but in practice there's nothing useful to do with such an exception except to fail the test. With this change we handle the interrupt within the utility methods instead, avoiding exception-handling noise in callers.
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Sep 16, 2024
Larger number of indexing operations can take a while to complete on slower machines for which we need to wait for longer. Relates: elastic#111957 Resolves: elastic#112423
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2024
ywangd
added a commit
to ywangd/elasticsearch
that referenced
this pull request
Sep 17, 2024
…12908) Larger number of indexing operations can take a while to complete on slower machines for which we need to wait for longer. Relates: elastic#111957 Resolves: elastic#112423
elasticsearchmachine
pushed a commit
that referenced
this pull request
Sep 17, 2024
MattAlp
added a commit
to MattAlp/elasticsearch
that referenced
this pull request
Jan 6, 2026
Merges the EsqlProject class into Project, eliminating unnecessary class hierarchy after the QL merge. Key changes: - Move lenient expressionsResolved() behavior from EsqlProject to Project, allowing UnsupportedAttribute to pass through projections unchanged - Add ESQL_PROJECT_ENTRY to PlanWritables for backward compatibility when deserializing old "EsqlProject" plans from mixed-version clusters - Add checkUnsupportedAttributeRenaming() to Verifier to ensure renaming UnsupportedAttribute via Alias is still blocked (this check now runs unconditionally, not gated by resolved() status) - Update all instantiation sites to use Project instead of EsqlProject - Update comments referencing EsqlProject Closes elastic#111957
MattAlp
added a commit
to MattAlp/elasticsearch
that referenced
this pull request
Jan 6, 2026
Merges the EsqlProject class into Project, eliminating unnecessary class hierarchy after the QL merge. Key changes: - Move lenient expressionsResolved() behavior from EsqlProject to Project, allowing UnsupportedAttribute to pass through projections unchanged - Add ESQL_PROJECT_ENTRY to PlanWritables for backward compatibility when deserializing old "EsqlProject" plans from mixed-version clusters - Add checkUnsupportedAttributeRenaming() to Verifier to ensure renaming UnsupportedAttribute via Alias is still blocked (this check now runs unconditionally, not gated by resolved() status) - Update all instantiation sites to use Project instead of EsqlProject - Update comments referencing EsqlProject Closes elastic#111957
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test utilities
waitUntil(),indexRandom(),startInParallel()and
runInParallel()all declareInterruptedExceptionamongst thechecked exceptions they throw, but in practice there's nothing useful to
do with such an exception except to fail the test. With this change we
handle the interrupt within the utility methods instead, avoiding
exception-handling noise in callers.