Skip to content

Dont sent TypeNameMarker as type, convert to type-strings #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2014
Merged

Dont sent TypeNameMarker as type, convert to type-strings #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9822b5b
Dont sent TypeNameMarker as type, convert to type-strings
Tasteful Aug 26, 2014
fde4409
Adding nullcheck and use Self.Types
Tasteful Aug 26, 2014
e5959ed
Add more unit-tests for IndicesStats
Tasteful Aug 26, 2014
15e1816
Remove duplicated code
Tasteful Aug 26, 2014
381afe9
Renamed parameter to types instead of completion_fields
Tasteful Aug 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Nest/DSL/IndicesStatsDescriptor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public partial class IndicesStatsDescriptor : IndicesOptionalPathDescriptor<Indi
IEnumerable<IndicesStatsMetric> IIndicesStatsRequest.Metrics { get; set; }

//<summary>A comma-separated list of fields for `completion` metric (supports wildcards)</summary>
public IndicesStatsDescriptor Types(params TypeNameMarker[] completion_fields)
public IndicesStatsDescriptor Types(params TypeNameMarker[] types)
{
Self.RequestParameters.AddQueryString("types", completion_fields);
Self.Types = types;
return this;
}

Expand Down
3 changes: 3 additions & 0 deletions src/Tests/Nest.Tests.Unit/BigBadUrlUnitTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,9 @@ public void TestAllTheUrls()
Do("POST", "/_bulk", c => c.IndexMany(Enumerable.Range(0, 10).Select(i => new Doc { Id = i.ToString() })));
Do("POST", "/customindex/customtype/_bulk", c => c.IndexMany(Enumerable.Range(0, 10).Select(i => new Doc { Id = i.ToString() }), index: "customindex", type: "customtype"));
Do("GET", "/_stats", c => c.IndicesStats());
Do("GET", "/my_index/_stats", c => c.IndicesStats(s => s.Index("my_index")));
Do("GET", "/my_index/_stats?types=type1", c => c.IndicesStats(s => s.Index("my_index").Types(new TypeNameMarker[] { "type1" })));
Do("GET", "/my_index/_stats?types=type1%2Ctype2", c => c.IndicesStats(s => s.Index("my_index").Types(new TypeNameMarker[] { "type1", "type2" })));
Do("GET", "/mydefaultindex/_stats", c => c.IndicesStats(s => s.Index<Doc>()));
Do("PUT", "/mydefaultindex/doc/_mapping", c => c.Map<Doc>(m => m.MapFromAttributes()));
Do("PUT", "/mycustomindex/doc/_mapping", c => c.Map<Doc>(m => m.Index("mycustomindex")));
Expand Down