Dont sent TypeNameMarker as type, convert to type-strings

[Tasteful]

TypeNameMarker was converted as NEST.TypeNameMarger in the querystring when fetching the _client.IndicesStats. Convert the TypeNameMarker as the correct type with the help of ElasticInferrer.

[gmarz]

@Tasteful great catch, thanks! Looks like this is failing one of the unit tests though: BigBadUrlUnitTests.TestAllTheUrls. Mind taking a look?

Also, small nit pick- can you change:

((IIndicesStatsRequest)this).Types = completion_fields; 

to

Self.Types = completion_fields;  

It's a pattern we've been following for convenience in all the descriptors so we don't have to continuously cast to the IRequest object.

[Tasteful]

@gmarz I have now updated the code to follow the pattern and added some more unit tests. It was a easy NullPointerException for the failed unit test so that was easy fixed.

[Tasteful]

@gmarz Maybe the parameter-name should be types instead of completion_fields in the IndicesStatsDescriptor.Types()?

[Mpdreamz]

@Tasteful +1 on renaming the parameter to types.

[Tasteful]

@gmarz Code updated.

[gmarz]

@Tasteful yes, I think the completion_fields param should be renamed to types.

Also, I left a note on your last commit. I think the code you added to UpdatePathInfo is already being done in IndicesStatsPathInfo.Update(), which checks the Types collection on the request instance that's passed to it. I think the only fix that was required here was changing that line to Self.Types = completion_fields in the Types() descriptor method.

The reason for the static IndicesStatsPathInfo.Update() is so that we ensure the path info modifications are applied to both IndicesStatsRequest and IndicesStatsDescriptor in the same manner. You'll see this is the pattern we follow in all the Descriptor files.

[gmarz]

@Tasteful LGTM now, thanks again for this!