Fix parsing of inet[/127.0.0.1:9200] #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: elastic#48 Signed-off-by: Robin H. Johnson <[email protected]>
Fixes: elastic#48 Signed-off-by: Robin H. Johnson <[email protected]>
|
💚 CLA has been signed |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thank you very much for this fix @robbat2! |
picandocodigo
pushed a commit
that referenced
this pull request
Jul 4, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 4, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 4, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this pull request
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detected while upgrading application from
elasticsearch-transport-1.0.6toelastic-transport-8Signed-off-by: Robin H. Johnson [email protected]