-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish_address ipv4 is mis-parsed as ipv6, leading to a undefined nil access and failure #48
Comments
robbat2
added a commit
to robbat2/elastic-transport-ruby
that referenced
this issue
Mar 22, 2023
Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: elastic#48 Signed-off-by: Robin H. Johnson <[email protected]>
robbat2
added a commit
to robbat2/elastic-transport-ruby
that referenced
this issue
Mar 22, 2023
Fixes: elastic#48 Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 4, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 4, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 4, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
picandocodigo
pushed a commit
that referenced
this issue
Jul 5, 2023
* sniffer: fix parsing of inet[hostname/ip:port] Prior to commit 53f37cb, publish_address of the format `inet[hostname/ip:port]` worked correctly. When the sniffer code was refactored, this format broke, and is an easy fix to restore. Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> * sniffer: fix empty hostname like inet[/127.0.0.1:9200] Fixes: #48 Signed-off-by: Robin H. Johnson <[email protected]> --------- Signed-off-by: Robin H. Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This leads to a failure in parse_publish_address
The text was updated successfully, but these errors were encountered: