-
Notifications
You must be signed in to change notification settings - Fork 135
[CI] Use GVM to install Golang on Windows #3377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
487644e
Use gvm to install Golang instead of chocolatey
mrodm 058eba7
Create a common file for windows functions
mrodm 4048771
Add cursor folder as ignored by git
mrodm 3a3f136
Add error.message field definition
mrodm 61511fd
Re-order calls to install Golang
mrodm 757ba56
Update system test package
mrodm 2938e8b
Test with 1.25.8
mrodm 1baca9f
Revert "Test with 1.25.8"
mrodm 0147e14
Remove cursor entry in gitignore
mrodm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Forcing to checkout again all the files with a correct autocrlf. | ||
| # Doing this here because we cannot set git clone options before. | ||
| function fixCRLF { | ||
| Write-Host "-- Fixing CRLF in git checkout --" | ||
| git config core.autocrlf input | ||
| git rm --quiet --cached -r . | ||
| git reset --quiet --hard | ||
| } | ||
|
|
||
| function ensureBinPath { | ||
| $workDir = if ($env:WORKSPACE) { $env:WORKSPACE } else { $PWD.Path } | ||
| $binDir = Join-Path $workDir "bin" | ||
| if (-not (Test-Path $binDir)) { New-Item -ItemType Directory -Path $binDir | Out-Null } | ||
| $env:PATH = "$binDir;$env:PATH" | ||
| return $binDir | ||
| } | ||
|
|
||
| function withGolang($version) { | ||
| Write-Host "--- Install golang (GVM)" | ||
| $binDir = ensureBinPath | ||
| $gvmExe = Join-Path $binDir "gvm-windows-amd64.exe" | ||
| $gvmUrl = "https://github.com/andrewkroh/gvm/releases/download/$env:SETUP_GVM_VERSION/gvm-windows-amd64.exe" | ||
|
|
||
| Write-Host "Installing GVM tool" | ||
| $maxTries = 5 | ||
| for ($i = 1; $i -le $maxTries; $i++) { | ||
| try { | ||
| Invoke-WebRequest -Uri $gvmUrl -OutFile $gvmExe -UseBasicParsing | ||
| break | ||
| } catch { | ||
| if ($i -eq $maxTries) { throw } | ||
| Start-Sleep -Seconds 3 | ||
| } | ||
| } | ||
|
|
||
| Write-Host "Installing Go version $version" | ||
| & $gvmExe --format=powershell $version | Invoke-Expression | ||
| $env:PATH = "$(go env GOPATH)\bin;$env:PATH" | ||
| go version | ||
| go env | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,3 +49,5 @@ | |
| - external: ecs | ||
| name: agent.id | ||
| dimension: true | ||
| - name: error.message | ||
| external: ecs | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added this field because of this error:
This is related to #3330 . Before the presence of this field
error.messagecause to fail the tests. As there is noevent.kind, the field validator is executed and that field was not defined.Example (buildkite link):