[CI] Use GVM to install Golang on Windows#3377
Conversation
| - name: error.message | ||
| external: ecs |
There was a problem hiding this comment.
Added this field because of this error:
test case failed: one or more errors found in documents stored in metrics-system.process-96148 data stream: [0] field "error.message" is undefined
This is related to #3330 . Before the presence of this field error.message cause to fail the tests. As there is no event.kind , the field validator is executed and that field was not defined.
Example (buildkite link):
test case failed: one or more errors found in documents stored in metrics-system.process-63529 data stream: [0] found error.message in event: [non fatal error; reporting partial metrics: error fetching PID metrics for 1 processes, most likely a "permission denied" error. Enable debug logging to determine the exact cause.]
💛 Build succeeded, but was flaky
Failed CI Steps
History
cc @mrodm |
This PR replaces Chocolatey-based Go installation with GVM in Windows CI steps, matching the approach used in package-registry#1617.
The shared PowerShell functions (
fixCRLF,ensureBinPath,withGolang) have been extracted into a newcommon_windows.ps1file, dot-sourced by bothunit_tests_windows.ps1andstack_tests_windows.ps1.Motivation
Chocolatey does not always have the latest Go patch versions available (e.g. 1.25.8 was missing), which blocks CI when
.go-versionis bumped. GVM downloads Go directly from the official releases, avoiding this dependency on Chocolatey's package update cycle.The
SETUP_GVM_VERSIONenvironment variable was already defined in.buildkite/pipeline.yml.Changes
.buildkite/scripts/common_windows.ps1(new): shared functions for CRLF fix, bin path setup, and GVM-based Go installation with retry logic..buildkite/scripts/unit_tests_windows.ps1: removed duplicated functions, dot-sourcescommon_windows.ps1..buildkite/scripts/stack_tests_windows.ps1: removed duplicated functions, dot-sourcescommon_windows.ps1. Docker/Docker Compose functions remain unchanged (still use Chocolatey).test/packages/parallel/system/: added missingerror.messagefield definition.Author's Checklist
.go-version(e.g. updating to1.25.8).systemtest package to includeerror.messagefield definition.References
Generated with the assistance of Cursor