Policy tests: order-independent OTel ID normalization#3318
Merged
mrodm merged 4 commits intoelastic:mainfrom Mar 2, 2026
Merged
Policy tests: order-independent OTel ID normalization#3318mrodm merged 4 commits intoelastic:mainfrom
mrodm merged 4 commits intoelastic:mainfrom
Conversation
Implement normalizePolicyToCanonical that rewrites OTel component IDs to deterministic type/componentid-N on the decoded YAML tree. Variable keys in extensions, receivers, processors, connectors, exporters, and service.pipelines are sorted by canonical value before assignment so equivalent policies with different map key order produce the same output.
Eliminate the replaceOTelComponentIDs function and integrate its logic into cleanPolicy. This change simplifies the policy cleaning process by directly normalizing the policy YAML to a canonical format, ensuring consistent output regardless of map key order. The updated implementation enhances readability and maintainability of the code.
Contributor
Author
|
test integrations |
|
Created or updated PR in integrations repository to test this version. Check elastic/integrations#17598 |
Collaborator
💚 Build Succeeded
History
cc @mrodm |
jsoriano
reviewed
Feb 27, 2026
jsoriano
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #3295
This PR replaces the regex-based OTel component ID replacement with a tree-based normalization (
normalizePolicyToCanonical).This new process normalizes the OTel sections (extensions, receivers, processors, etc.) by sorting variable keys so equivalent policies with different map key order compare equal.
Add tests for the new normalization behavior.
Author's Checklist
elastic-package test policy --generatekeeps generating valid expected filesuse_apmvariable in policy and system tests in input packages #3295 (comment)elasticapm_input_otelpackage being developed in Add Elastic APM Intake OpenTelemetry Input Package integrations#17114Generated PR with the assistance of Cursor AI.