Skip to content

Allow overriding AGENT_PACKAGE_VERSION and MANIFEST_URL when USE_PACKAGE_VERSION=true #9864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchila merged 3 commits into from
Sep 11, 2025
Merged

Allow overriding AGENT_PACKAGE_VERSION and MANIFEST_URL when USE_PACKAGE_VERSION=true #9864

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ec8dcf
Allow overriding AGENT_PACKAGE_VERSION and MANIFEST_URL when USE_PACK…
pchila Sep 10, 2025
f280b43
Update dev-tools/mage/settings.go
pchila Sep 11, 2025
b6c45eb
fix lint errors
pchila Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions dev-tools/mage/settings.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,17 +162,18 @@ func initGlobals() {

versionQualifier, versionQualified = os.LookupEnv("VERSION_QUALIFIER")

agentPackageVersion = EnvOr(agentPackageVersionEnvVar, "")

ManifestURL = EnvOr(ManifestUrlEnvVar, "")
PackagingFromManifest = ManifestURL != ""

// order matters this must be called last as it will override some of the
// values above
Comment thread
pchila marked this conversation as resolved.
Outdated
err = initPackageVersion()
if err != nil {
panic(fmt.Errorf("failed to init package version: %w", err))
}

agentPackageVersion = EnvOr(agentPackageVersionEnvVar, agentPackageVersion)

ManifestURL = EnvOr(ManifestUrlEnvVar, ManifestURL)
PackagingFromManifest = ManifestURL != ""

}

// ProjectType specifies the type of project (OSS vs X-Pack).
Expand Down
Loading