Skip to content

Unpin VM images#8153

Merged
dliappis merged 1 commit into
elastic:mainfrom
dliappis:unpin-vm-images
May 15, 2025
Merged

Unpin VM images#8153
dliappis merged 1 commit into
elastic:mainfrom
dliappis:unpin-vm-images

Conversation

@dliappis
Copy link
Copy Markdown
Contributor

@dliappis dliappis commented May 15, 2025

What does this PR do?

This commit reverts the version pinning done for VM images in #7958, now that VM images used a pinned version of asdf-golang.

How to test this PR locally

Only testable in Buildkite CI -- CI ought to get green and especially the check-ci step in unit tests should be green.

@dliappis dliappis self-assigned this May 15, 2025
@dliappis dliappis requested review from a team as code owners May 15, 2025 10:58
@dliappis dliappis added the ci label May 15, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 15, 2025

This pull request does not have a backport label. Could you fix it @dliappis? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@dliappis dliappis force-pushed the unpin-vm-images branch 2 times, most recently from f770a47 to a5d6cdc Compare May 15, 2025 11:11
@dliappis
Unpin VM images
f8a4534 
This commit reverts the version pinning done for VM images
in elastic#7958, now that VM images used a pinned version of
asdf-golang.
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube Bot commented May 15, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dliappis dliappis added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels May 15, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 15, 2025

💚 Build Succeeded

cc @dliappis

@dliappis dliappis merged commit 6d89a78 into elastic:main May 15, 2025
14 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 15, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented May 15, 2025 •
edited
Loading

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
6801012 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
@mergify mergify Bot mentioned this pull request May 15, 2025
Merged
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
c2da907 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
dcc0f3a 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
This was referenced May 15, 2025
Merged
Merged
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
43aaa0f 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
@mergify mergify Bot mentioned this pull request May 15, 2025
Merged
dliappis added a commit that referenced this pull request May 15, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8156)
119902f 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request May 16, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8157)
a1a2502 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request May 16, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8158)
1f19383 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request May 16, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8155)
fcab02b 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
v1v added a commit to v1v/elastic-agent that referenced this pull request May 22, 2025
@v1v
Revert "Unpin VM images (elastic#8153)"
e49e283 
This reverts commit 6d89a78.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@oakrizan oakrizan oakrizan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dliappis dliappis

Labels

backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches ci skip-changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dliappis @elasticmachine @oakrizan