Skip to content

Pin VM version for check-ci#7958

Merged
oakrizan merged 1 commit into
mainfrom
pin-vm-version-for-check-ci
Apr 24, 2025
Merged

Pin VM version for check-ci#7958
oakrizan merged 1 commit into
mainfrom
pin-vm-version-for-check-ci

Conversation

@oakrizan
Copy link
Copy Markdown
Contributor

@oakrizan oakrizan commented Apr 24, 2025 •
edited
Loading

What does this PR do?

Pinning versions of VM images in the pipelines

Why is it important?

Required to avoid spontaneous failures caused by regular image update && promotion.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 24, 2025

This pull request does not have a backport label. Could you fix it @oakrizan? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

v1v
v1v previously approved these changes Apr 24, 2025
View reviewed changes
@oakrizan oakrizan force-pushed the pin-vm-version-for-check-ci branch from 00c1dd7 to 6ee9752 Compare April 24, 2025 10:49
@oakrizan oakrizan added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels Apr 24, 2025
@oakrizan oakrizan marked this pull request as ready for review April 24, 2025 10:59
@oakrizan oakrizan requested review from a team as code owners April 24, 2025 10:59
@oakrizan oakrizan requested a review from v1v April 24, 2025 10:59
@oakrizan oakrizan added Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team ci labels Apr 24, 2025
v1v
v1v previously approved these changes Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for using a centralised place to set those VM images!

@oakrizan oakrizan force-pushed the pin-vm-version-for-check-ci branch 2 times, most recently from 531e718 to 4fff76f Compare April 24, 2025 11:33
@oakrizan oakrizan force-pushed the pin-vm-version-for-check-ci branch from 4fff76f to 8078e78 Compare April 24, 2025 11:38
@elastic-sonarqube
Copy link
Copy Markdown

elastic-sonarqube Bot commented Apr 24, 2025

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 24, 2025

💚 Build Succeeded

cc @oakrizan

@pkoutsovasilis pkoutsovasilis requested a review from v1v April 24, 2025 13:20
@oakrizan oakrizan merged commit 1f77033 into main Apr 24, 2025
12 checks passed
@oakrizan oakrizan deleted the pin-vm-version-for-check-ci branch April 24, 2025 13:26
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2025

@Mergifyio backport 8.17 8.18 8.19 9.0

@mergify
Copy link
Copy Markdown
Contributor

mergify Bot commented Apr 24, 2025 •
edited
Loading

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

Details

mergify Bot pushed a commit that referenced this pull request Apr 24, 2025
@oakrizan @mergify
pinned version (#7958)
662844f 
(cherry picked from commit 1f77033)

# Conflicts:
#	.buildkite/pipeline.yml
mergify Bot pushed a commit that referenced this pull request Apr 24, 2025
@oakrizan @mergify
pinned version (#7958)
98990fc 
(cherry picked from commit 1f77033)

# Conflicts:
#	.buildkite/pipeline.yml
This was referenced Apr 24, 2025
Merged
Merged
mergify Bot pushed a commit that referenced this pull request Apr 24, 2025
@oakrizan @mergify
pinned version (#7958)
adb685c 
(cherry picked from commit 1f77033)
@mergify mergify Bot mentioned this pull request Apr 24, 2025
Merged
8 tasks
mergify Bot pushed a commit that referenced this pull request Apr 24, 2025
@oakrizan @mergify
pinned version (#7958)
f414de3 
(cherry picked from commit 1f77033)

# Conflicts:
#	.buildkite/pipeline.yml
@mergify mergify Bot mentioned this pull request Apr 24, 2025
Merged
8 tasks
v1v pushed a commit that referenced this pull request Apr 24, 2025
@mergify @oakrizan
pinned version (#7958) (#7967)
50a756c 
(cherry picked from commit 1f77033)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Apr 24, 2025
@mergify @oakrizan
[8.17] (backport #7958) Pin VM version for check-ci (#7965)
805dc44 
* pinned version (#7958)

(cherry picked from commit 1f77033)

---------

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Apr 24, 2025
@mergify @oakrizan
[8.18] (backport #7958) Pin VM version for check-ci (#7966)
bdc1188 
* pinned version (#7958)

(cherry picked from commit 1f77033)

---------

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request Apr 24, 2025
@mergify @oakrizan
[9.0] (backport #7958) Pin VM version for check-ci (#7968)
718eea4 
* pinned version (#7958)

(cherry picked from commit 1f77033)

---------

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
@v1v v1v mentioned this pull request May 9, 2025
Closed
6 tasks
dliappis added a commit to dliappis/elastic-agent that referenced this pull request May 15, 2025
@dliappis
Unpin VM images
9b02354 
This commit reverts the version pinning done for VM images
in elastic#7958, now that VM images used a pinned version of
asdf-golang.
@dliappis dliappis mentioned this pull request May 15, 2025
Merged
dliappis added a commit to dliappis/elastic-agent that referenced this pull request May 15, 2025
@dliappis
Unpin VM images
f770a47 
This commit reverts the version pinning done for VM images
in elastic#7958, now that VM images used a pinned version of
asdf-golang.
dliappis added a commit to dliappis/elastic-agent that referenced this pull request May 15, 2025
@dliappis
Unpin VM images
a5d6cdc 
This commit reverts the version pinning done for VM images
in elastic#7958, now that VM images used a pinned version of
asdf-golang.
dliappis added a commit to dliappis/elastic-agent that referenced this pull request May 15, 2025
@dliappis
Unpin VM images
f8a4534 
This commit reverts the version pinning done for VM images
in elastic#7958, now that VM images used a pinned version of
asdf-golang.
dliappis added a commit that referenced this pull request May 15, 2025
@dliappis
Unpin VM images (#8153)
6d89a78 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
6801012 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
@mergify mergify Bot mentioned this pull request May 15, 2025
Merged
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
c2da907 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
dcc0f3a 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
This was referenced May 15, 2025
Merged
Merged
mergify Bot pushed a commit that referenced this pull request May 15, 2025
@dliappis @mergify
Unpin VM images (#8153)
43aaa0f 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)
@mergify mergify Bot mentioned this pull request May 15, 2025
Merged
dliappis added a commit that referenced this pull request May 15, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8156)
119902f 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request May 16, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8157)
a1a2502 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request May 16, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8158)
1f19383 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis added a commit that referenced this pull request May 16, 2025
@mergify @dliappis
Unpin VM images (#8153) (#8155)
fcab02b 
This commit reverts the version pinning done for VM images
in #7958, now that VM images used a pinned version of
asdf-golang.

(cherry picked from commit 6d89a78)

Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@v1v v1v v1v approved these changes

+1 more reviewer

@pkoutsovasilis pkoutsovasilis pkoutsovasilis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@oakrizan oakrizan

Labels

backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches ci skip-changelog Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oakrizan @elasticmachine @v1v @pkoutsovasilis