Conversation
…tE2E (#6819) * otel: fix flaky behavior on TestFBOtelRestartE2E This test starts the collector with a timeout, but the error returned is not always a context cancelled, sometimes it returns err == nil, which is also fine, just not handled properly. While at it, fix some other issues I found while testing: - Using require inside a goroutine calls runtime.GoExit on failure, meaning the test exits immediatelly without doing any cleanup. Use assert in those cases. * don't fail if ignored field is equal * use a different index name to avoid conflicts * Update testing/integration/otel_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Update testing/integration/otel_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * use assert.Conditionf for error check --------- Co-authored-by: Khushi Jain <khushi.jain@elastic.co> Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> (cherry picked from commit 82460a2)
mergify
bot
requested review from
pchila and
ycombinator
and removed request for
a team
github-actions
bot
added
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
mauri870
approved these changes
Apr 28, 2025
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This test starts the collector with a timeout, but the error returned is not
always a context cancelled, sometimes it returns err == nil, which is also
fine, just not handled properly.
While at it, fix some other issues I found while testing:
the test exits immediatelly without doing any cleanup, causing resource leaks. Use assert in those
cases.
Checklist
./changelog/fragmentsusing the changelog toolRelated issues
This is an automatic backport of pull request otel: fix flakiness and enable logs_dynamic_id in TestFBOtelRestartE2E #6819 done by Mergify.