otel: fix flakiness and enable logs_dynamic_id in TestFBOtelRestartE2E#6819
Merged
mauri870 merged 17 commits intoelastic:mainfrom Apr 28, 2025
Merged
otel: fix flakiness and enable logs_dynamic_id in TestFBOtelRestartE2E#6819mauri870 merged 17 commits intoelastic:mainfrom
mauri870 merged 17 commits intoelastic:mainfrom
Conversation
mauri870
added
Team:Elastic-Agent-Data-Plane
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
mauri870
changed the title
pierrehilbert
added
the
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
mauri870
force-pushed
the
otel-restart-test-duplicates
branch
from
adc2425 to
d8d9cb2
Compare
swiatekm
approved these changes
Feb 12, 2025
Member
Author
|
Moving this to draft since it requires work done in beats via elastic/beats#42412 . I need to bump the beats dependency in go.mod #6837. |
mauri870
force-pushed
the
otel-restart-test-duplicates
branch
from
dc95b0a to
d04606e
Compare
mauri870
changed the title
mauri870
changed the title
Member
Author
|
I'm repurposing this PR to include a series of fixes for the otel tests. Having the fixes as a batch as oposed to separate PRs speeds up the continuous integration builds. |
This test starts the collector with a timeout, but the error returned is not always a context cancelled, sometimes it returns err == nil, which is also fine, just not handled properly. While at it, fix some other issues I found while testing: - Using require inside a goroutine calls runtime.GoExit on failure, meaning the test exits immediatelly without doing any cleanup. Use assert in those cases.
mauri870
force-pushed
the
otel-restart-test-duplicates
branch
from
d04606e to
95c25c9
Compare
swiatekm
previously approved these changes
Feb 20, 2025
auto-merge was automatically disabled
February 26, 2025 14:27
Pull request was converted to draft
Member
Author
|
Leaving this as draft since we had to remove all the tests as a part of a last ditch fix for EDOT in v9.0. I will revisit this once #7023 is reverted. |
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
|
ycombinator
added
backport-8.19
mauri870
changed the title
|
swiatekm
approved these changes
Apr 28, 2025
leehinman
approved these changes
Apr 28, 2025
VihasMakwana
approved these changes
Apr 28, 2025
Contributor
💚 Build Succeeded
History
cc @mauri870 |
mauri870
changed the title
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tE2E (#6819) * otel: fix flaky behavior on TestFBOtelRestartE2E This test starts the collector with a timeout, but the error returned is not always a context cancelled, sometimes it returns err == nil, which is also fine, just not handled properly. While at it, fix some other issues I found while testing: - Using require inside a goroutine calls runtime.GoExit on failure, meaning the test exits immediatelly without doing any cleanup. Use assert in those cases. * don't fail if ignored field is equal * use a different index name to avoid conflicts * Update testing/integration/otel_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Update testing/integration/otel_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * use assert.Conditionf for error check --------- Co-authored-by: Khushi Jain <khushi.jain@elastic.co> Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> (cherry picked from commit 82460a2)
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
…tE2E (#6819) * otel: fix flaky behavior on TestFBOtelRestartE2E This test starts the collector with a timeout, but the error returned is not always a context cancelled, sometimes it returns err == nil, which is also fine, just not handled properly. While at it, fix some other issues I found while testing: - Using require inside a goroutine calls runtime.GoExit on failure, meaning the test exits immediatelly without doing any cleanup. Use assert in those cases. * don't fail if ignored field is equal * use a different index name to avoid conflicts * Update testing/integration/otel_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * Update testing/integration/otel_test.go Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> * use assert.Conditionf for error check --------- Co-authored-by: Khushi Jain <khushi.jain@elastic.co> Co-authored-by: Paolo Chilà <paolo.chila@elastic.co> (cherry picked from commit 82460a2)
mauri870
added a commit
that referenced
this pull request
Apr 28, 2025
…tE2E (#6819) (#8007) * otel: fix flaky behavior on TestFBOtelRestartE2E This test starts the collector with a timeout, but the error returned is not always a context cancelled, sometimes it returns err == nil, which is also fine, just not handled properly. While at it, fix some other issues I found while testing: - Using require inside a goroutine calls runtime.GoExit on failure, meaning the test exits immediatelly without doing any cleanup. Use assert in those cases. * don't fail if ignored field is equal * use a different index name to avoid conflicts * Update testing/integration/otel_test.go * Update testing/integration/otel_test.go * use assert.Conditionf for error check --------- (cherry picked from commit 82460a2) Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Co-authored-by: Khushi Jain <khushi.jain@elastic.co> Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
mauri870
added a commit
that referenced
this pull request
Apr 28, 2025
…tE2E (#6819) (#8006) * otel: fix flaky behavior on TestFBOtelRestartE2E This test starts the collector with a timeout, but the error returned is not always a context cancelled, sometimes it returns err == nil, which is also fine, just not handled properly. While at it, fix some other issues I found while testing: - Using require inside a goroutine calls runtime.GoExit on failure, meaning the test exits immediatelly without doing any cleanup. Use assert in those cases. * don't fail if ignored field is equal * use a different index name to avoid conflicts * Update testing/integration/otel_test.go * Update testing/integration/otel_test.go * use assert.Conditionf for error check --------- (cherry picked from commit 82460a2) Co-authored-by: Mauri de Souza Meneguzzo <mauri870@gmail.com> Co-authored-by: Khushi Jain <khushi.jain@elastic.co> Co-authored-by: Paolo Chilà <paolo.chila@elastic.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This test starts the collector with a timeout, but the error returned is not
always a context cancelled, sometimes it returns err == nil, which is also
fine, just not handled properly.
While at it, fix some other issues I found while testing:
the test exits immediatelly without doing any cleanup, causing resource leaks. Use assert in those
cases.
Checklist
./changelog/fragmentsusing the changelog toolRelated issues