Enhancement/5039 remove x crypto fips by kaanyalti · Pull Request #7072 · elastic/elastic-agent

kaanyalti · 2025-02-28T00:17:48Z

Enhancement

What does this PR do?

Removes x/crypto usage

Why is it important?

We need to move away from using x/crypto for fips compliance

Checklist

I have read and understood the pull request guidelines of this project.
My code follows the style guidelines of this project
~~[ ] I have commented my code, particularly in hard-to-understand areas~~
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
~~[ ] I have added tests that prove my fix is effective or that my feature works~~
I have added an entry in ./changelog/fragments using the changelog tool
~~[ ] I have added an integration test or an E2E test~~

Disruptive User Impact

None

How to test this PR locally

Ci tests should be enough

Related issues

mergify · 2025-02-28T00:18:25Z

This pull request does not have a backport label. Could you fix it @kaanyalti? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

kaanyalti · 2025-03-01T08:36:18Z

Blocked until go version can be bumped up to 1.24

kaanyalti · 2025-03-06T18:29:51Z

unblocked, go version bumped is merged

kruskall

LGTM!

just a minor question for the agent team

elasticmachine · 2025-03-07T07:44:47Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

simitt

Thanks!

pchila

Looks good, we just need to split off the beats bump to a separate PR and remove the changelog.

Waiting for a green CI before approval

mergify · 2025-03-10T16:25:18Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5039_remove_x_crypto_fips upstream/enhancement/5039_remove_x_crypto_fips
git merge upstream/main
git push upstream enhancement/5039_remove_x_crypto_fips

swiatekm

LGTM. Left a comment about moving values to named constants, but I'm ok with this being merged without it having been addressed.

mergify · 2025-03-11T14:14:40Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b enhancement/5039_remove_x_crypto_fips upstream/enhancement/5039_remove_x_crypto_fips
git merge upstream/main
git push upstream enhancement/5039_remove_x_crypto_fips

elastic-sonarqube · 2025-03-12T14:20:50Z

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
72.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

elasticmachine · 2025-03-12T16:40:37Z

💔 Build Failed

Buildkite Build
Commit: c74486f

Failed CI Steps

History

💔 Build #18576 failed c74486f
💔 Build #18571 failed 8aa3577
💔 Build #18492 failed 3448c20
💔 Build #18487 failed 2e754d1

cc @kaanyalti

* enhancement(5039): replace x/crypto/pbkdf2 with stdlib pbkdf2 * enhancement(5039): added nolint comment (cherry picked from commit 33df025)

* enhancement(5039): replace x/crypto/pbkdf2 with stdlib pbkdf2 * enhancement(5039): added nolint comment (cherry picked from commit 33df025) Co-authored-by: Kaan Yalti <kaan.yalti@elastic.co>

mergify Bot assigned kaanyalti Feb 28, 2025

kruskall reviewed Feb 28, 2025

View reviewed changes

Comment thread go.mod

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from 65d0fb3 to 8e74a0a Compare March 1, 2025 08:35

kaanyalti marked this pull request as ready for review March 1, 2025 08:36

kaanyalti requested a review from a team as a code owner March 1, 2025 08:36

kaanyalti requested review from pchila and swiatekm March 1, 2025 08:36

kaanyalti marked this pull request as draft March 1, 2025 08:36

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from df255d7 to 8d17eea Compare March 5, 2025 23:16

kaanyalti mentioned this pull request Mar 6, 2025

enhancement(5039): bump up go version to 1.24, replace pbkdf2 with stdlib pbkdf2 elastic/elastic-agent-libs#291

Closed

1 task

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from 8d17eea to ecea4ae Compare March 6, 2025 18:26

kaanyalti marked this pull request as ready for review March 6, 2025 18:29

kruskall previously approved these changes Mar 6, 2025

View reviewed changes

Comment thread changelog/fragments/1740817861-remove-some-x-crypto-usage.yaml Outdated

kruskall reviewed Mar 6, 2025

View reviewed changes

Comment thread go.mod Outdated

pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Mar 7, 2025

simitt previously approved these changes Mar 7, 2025

View reviewed changes

swiatekm reviewed Mar 7, 2025

View reviewed changes

Comment thread go.mod Outdated

pchila reviewed Mar 10, 2025

View reviewed changes

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from ecea4ae to 978420a Compare March 10, 2025 14:32

kaanyalti dismissed stale reviews from simitt and kruskall via a887c28 March 10, 2025 14:32

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from db2dc3e to 573d9d8 Compare March 10, 2025 17:22

kaanyalti added the skip-changelog label Mar 10, 2025

kruskall reviewed Mar 10, 2025

View reviewed changes

Comment thread go.mod Outdated

swiatekm previously approved these changes Mar 11, 2025

View reviewed changes

Comment thread internal/pkg/agent/vault/vault_file_notwindows.go Outdated

kaanyalti dismissed swiatekm’s stale review via 8aa3577 March 12, 2025 04:51

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from 8aa3577 to cae5b1a Compare March 12, 2025 05:06

enhancement(5039): replace x/crypto/pbkdf2 with stdlib pbkdf2

f4dd9cb

kaanyalti force-pushed the enhancement/5039_remove_x_crypto_fips branch from f1df84d to f4dd9cb Compare March 12, 2025 05:40

enhancement(5039): added nolint comment

c74486f

kaanyalti requested review from kruskall, pchila, simitt and swiatekm March 12, 2025 13:20

kaanyalti added backport-8.x Automated backport to the 8.x branch with mergify backport-9.0 Automated backport to the 9.0 branch labels Mar 12, 2025

swiatekm approved these changes Mar 14, 2025

View reviewed changes

pchila approved these changes Mar 14, 2025

View reviewed changes

kaanyalti merged commit 33df025 into elastic:main Mar 14, 2025

kaanyalti deleted the enhancement/5039_remove_x_crypto_fips branch March 14, 2025 14:29

mergify Bot pushed a commit that referenced this pull request Mar 14, 2025

Enhancement/5039 remove x crypto fips (#7072)

0707352

* enhancement(5039): replace x/crypto/pbkdf2 with stdlib pbkdf2 * enhancement(5039): added nolint comment (cherry picked from commit 33df025)

mergify Bot mentioned this pull request Mar 14, 2025

[8.x](backport #7072) Enhancement/5039 remove x crypto fips #7421

Merged

3 tasks

mergify Bot pushed a commit that referenced this pull request Mar 14, 2025

Enhancement/5039 remove x crypto fips (#7072)

c88652d

* enhancement(5039): replace x/crypto/pbkdf2 with stdlib pbkdf2 * enhancement(5039): added nolint comment (cherry picked from commit 33df025)

mergify Bot mentioned this pull request Mar 14, 2025

[9.0](backport #7072) Enhancement/5039 remove x crypto fips #7422

Merged

3 tasks

Conversation

kaanyalti commented Feb 28, 2025 • edited by jlind23 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Disruptive User Impact

How to test this PR locally

Related issues

Uh oh!

mergify Bot commented Feb 28, 2025

Uh oh!

Uh oh!

kaanyalti commented Mar 1, 2025

Uh oh!

kaanyalti commented Mar 6, 2025

Uh oh!

kruskall left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

elasticmachine commented Mar 7, 2025

Uh oh!

simitt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pchila left a comment

Choose a reason for hiding this comment

Uh oh!

mergify Bot commented Mar 10, 2025

Uh oh!

Uh oh!

swiatekm left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mergify Bot commented Mar 11, 2025

Uh oh!

elastic-sonarqube Bot commented Mar 12, 2025

Quality Gate passed

Uh oh!

elasticmachine commented Mar 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

kaanyalti commented Feb 28, 2025 •

edited by jlind23

Loading

elasticmachine commented Mar 12, 2025 •

edited

Loading