[8.x](backport #5349) Add elastic-agent-service container to packaging#5634
[8.x](backport #5349) Add elastic-agent-service container to packaging#5634pierrehilbert merged 8 commits into8.xfrom
Conversation
Adds the elastic-agent-service container with the py-connectors component enabled. (cherry picked from commit 701f8b9) # Conflicts: # dev-tools/mage/manifest/manifest.go
|
Cherry-pick of 701f8b9 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
jlind23
left a comment
There was a problem hiding this comment.
This change broke the unified release on main, I would hold off before this is fixed on main.
Probably should merge this PR and the |
Fix conflicts caused by mergify
…hives (#5647) This commit modifies movePackagesToArchive() function to include python wheel packages introduced with commit 701f8b9 . This solves an issue when packaging docker images using a DROP_PATH env var: prior to this change, the python wheel archives present in DROP_PATH were not moved to `<DROP PATH>/archive/<platform>` failing to create an image for which the Dockerfile expects to install the python wheel package
|
Wait I don't think we want this in 8.x, right? |
|
Disabling auto-merge out of an abundance of caution - I don't want anything to sneak into 8.16.0-SNAPSHOT that the agentless team isn't ready for. |
|
@seanstory I assumed this was going into 8.16. If it's 9.0 only then we don't need this. |
|
Relevant thread here: https://github.com/elastic/ingest-dev/issues/3767#issuecomment-2388796205 My team doesn't need this for 8.16.x, but perhaps the agentless team would rather use the new image sooner than later. |
@tehilashn @olegsu any answer for Sean's point? If you don't need the new variant then we'll keep this change in 9.0 instead of backporting it to 8.x. |
|
@oren-zohar @orestisfl - do we need this for 8.16? |
No, as far as I'm aware, the search connectors will not be supported for 8.16.x. We might want it for the next 8.x, even if the connectors are only planned for 9.0, just for testing, but for 8.16 we can skip it |
|
This pull request has not been merged yet. Could you please review and merge it @blakerouse? 🙏 |
|
Thanks @oren-zohar, I'll close this PR for now and will reopen later if we need it in 8.17+. |
Force merging to unblock the unified release process
|
We are re-opening this PR to be merged into 8.x, but only after the 8.16 release is cut. This PR has two follow-up PR fixes already merged in so that when it goes into 8.x it doesn't cause any issues. |
|
|
This pull request has not been merged yet. Could you please review and merge it @blakerouse? 🙏 |





What does this PR do?
Adds a new docker variant of
elastic-agent-servicethat includes the python connectors.Currently this PR includes the following PR until that PR is merged - #5338
Why is it important?
Used by the Elastic Agent service.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in(not really user facing at this level)./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testDisruptive User Impact
None.
How to test this PR locally
This is an automatic backport of pull request #5349 done by [Mergify](https://mergify.com).