Add ability to build specific docker variants#5338
Merged
blakerouse merged 2 commits intoelastic:mainfrom Aug 28, 2024
Merged
Conversation
blakerouse
added
Team:Elastic-Agent-Control-Plane
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
blakerouse
changed the title
|
2 tasks
pchila
approved these changes
Aug 27, 2024
Member
pchila
left a comment
pchila
left a comment
There was a problem hiding this comment.
Just a small suggestion, non-blocking.
Looks good 👍
Comment on lines
+136
to
+141
| for _, v := range SelectedDockerVariants { | ||
| if v == docVariant { | ||
| return true | ||
| } | ||
| } | ||
| return false |
Member
There was a problem hiding this comment.
Nit: we can use something more compact:
Suggested change
| for _, v := range SelectedDockerVariants { | |
| if v == docVariant { | |
| return true | |
| } | |
| } | |
| return false | |
| return slices.Contains(SelectedDockerVariants, docVariant) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds ability to adjust package building to build only a subset of docker image variants.
Why is it important?
Helps with developer velocity, where iterating on an image is quicker because you can select only a specific variant to build.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works(dev-tools/ only)[ ] I have added an entry in(dev-tools/ only)./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E test(dev-tools/ only)Disruptive User Impact
None
How to test this PR locally
Build a specific image variant:
Build a specific subset variant:
Build all variants: