Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.13](backport #4459) Fix MacOS compatibility script syntax #4460

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 21, 2024

What does this PR do?

Fix syntax in compatibility script for MacOS originally introduced in #1392 and modified for #4193. Modification introduced in #4193 contains a syntax error that this PR fixes

Why is it important?

Upgrade from elastic-agent < 8.5.0 needs this script to correct the target for link /Library/Elastic/Agent/elastic-agent to the actual elastic-agent binary

Checklist

  • My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

This is an automatic backport of pull request #4459 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner March 21, 2024 19:30
@mergify mergify bot added the backport label Mar 21, 2024
@mergify mergify bot requested review from blakerouse and pchila and removed request for a team March 21, 2024 19:30
@mergify mergify bot assigned pchila Mar 21, 2024
@cmacknz
Copy link
Member

cmacknz commented Mar 21, 2024

Force merging, CI unfortunately doesn't verify this particular script right now

@cmacknz cmacknz merged commit 818d204 into 8.13 Mar 21, 2024
7 of 8 checks passed
@cmacknz cmacknz deleted the mergify/bp/8.13/pr-4459 branch March 21, 2024 19:31
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants