Fix MacOS compatibility script syntax #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchila
added
bug
|
This pull request does not have a backport label. Could you fix it @pchila? 🙏
NOTE: |
cmacknz
approved these changes
Mar 21, 2024
pchila
added
skip-changelog
backport-v8.13.0
cmacknz
added
backport-skip
backport-v8.13.0
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
Upgrade of 7.17.18 to 8.14.0-SNAPSHOT from this branch succeeded for me with a manual test. |
|
Force merging, integration tests remaining do not run on MacOS. |
|
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
(cherry picked from commit 08bd15e)
1 task
cmacknz
pushed a commit
that referenced
this pull request
Mar 21, 2024
(cherry picked from commit 08bd15e) Co-authored-by: Paolo Chilà <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix syntax in compatibility script for MacOS originally introduced in #1392 and modified for #4193. Modification introduced in #4193 contains a syntax error that this PR fixes
Why is it important?
Upgrade from elastic-agent < 8.5.0 needs this script to correct the target for link
/Library/Elastic/Agent/elastic-agentto the actual elastic-agent binaryChecklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E testAuthor's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
Questions to ask yourself