[updatecli][githubrelease] Bump version to 1.19.8

[ghost]

[updatecli][githubrelease] Bump version to 1.19.8

It requires the version to be bumped first in golang-crossbuild project, then a new release will be added to:
https://github.com/elastic/golang-crossbuild/releases/tag/v1.19.8.
Otherwise it will fail until the docker images are available.

Report

Source:
	✔ [gomod] Get version in go.mod format(shell)
	✔ [latestGoVersion] Get Latest Go Release(githubrelease)
	✔ [minor] Get minor version in .go-version(shell)


Condition:
	✔ [dockerTag] Is docker image golang:1.19.8 published(dockerimage)
	✔ [goDefaultVersion-check] Check if defined golang version differs(shell)

Target:
	✔ [update-dockerfiles] Update from dockerfiles(file)
	✔ [update-go-version] Update .go-version(file)
	✔ [update-golang.ci] Update .golangci.yml(file)
	✔ [update-gomod] Update go.mod(file)
	✔ [update-version.asciidoc] Update version.asciidoc(file)

Changelog

Click to expand

no GitHub Release found for go1.19.8 on "https://github.com/golang/go"

Remark

This pull request was automatically created using Updatecli.

Please report any issues with this tool here

[elasticmachine]

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

• Start Time: 2023-04-08T20:01:53.174+0000

• Duration: 22 min 51 sec

Test stats 🧪

Test	Results
Failed	0
Passed	5423
Skipped	23
Total	5446

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

• /test : Re-trigger the build.

• /package : Generate the packages.

• run integration tests : Run the Elastic Agent Integration tests.

• run end-to-end tests : Generate the packages and run the E2E Tests.

• run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

[elasticmachine]

🌐 Coverage report

Name	Metrics % (covered/total)	Diff
Packages	98.507% (66/67)	👍
Files	69.432% (159/229)	👍
Classes	68.65% (300/437)	👍
Methods	53.968% (918/1701)	👍
Lines	39.034% (10273/26318)	👍 0.004
Conditionals	100.0% (0/0)	💚

[ycombinator]

Unfortunately, this PR being merged before elastic/golang-crossbuild#282 is causing Agent builds to be broken on main, for example: https://fleet-ci.elastic.co/job/elastic-agent/job/elastic-agent-mbp/job/main/908/console:

10:51:27  >> golangCrossBuild: Building for linux/arm64
10:51:27  >> buildGoDaemon: Building for linux/arm64
10:51:27  Unable to find image 'docker.elastic.co/beats-dev/golang-crossbuild:1.19.8-arm' locally
10:51:27  Unable to find image 'docker.elastic.co/beats-dev/golang-crossbuild:1.19.8-arm' locally
10:51:28  docker: Error response from daemon: manifest for docker.elastic.co/beats-dev/golang-crossbuild:1.19.8-arm not found: manifest unknown: manifest unknown.
10:51:28  See 'docker run --help'.
10:51:28  docker: Error response from daemon: manifest for docker.elastic.co/beats-dev/golang-crossbuild:1.19.8-arm not found: manifest unknown: manifest unknown.
10:51:28  See 'docker run --help'.
10:51:28  package ran for 1m23.959849782s
10:51:28  Error: running "docker run --env EXEC_UID=1147 --env EXEC_GID=1147 -v /var/lib/jenkins/workspace/tic-agent_elastic-agent-mbp_main/pkg/mod:/go/pkg/mod:ro --rm --env GOFLAGS=-mod=readonly --env MAGEFILE_VERBOSE= --env MAGEFILE_TIMEOUT= --env SNAPSHOT=true --env DEV=true --env EXTERNAL=true -v /var/lib/jenkins/workspace/tic-agent_elastic-agent-mbp_main/src/github.com/elastic/elastic-agent:/go/src/github.com/elastic/elastic-agent -w /go/src/github.com/elastic/elastic-agent docker.elastic.co/beats-dev/golang-crossbuild:1.19.8-arm --build-cmd build/mage-linux-arm64 buildGoDaemon --platforms linux/arm64" failed with exit code 125
10:51:28  running "docker run --env EXEC_UID=1147 --env EXEC_GID=1147 -v /var/lib/jenkins/workspace/tic-agent_elastic-agent-mbp_main/pkg/mod:/go/pkg/mod:ro --rm --env GOFLAGS=-mod=readonly --env MAGEFILE_VERBOSE= --env MAGEFILE_TIMEOUT= --env SNAPSHOT=true --env DEV=true --env EXTERNAL=true -v /var/lib/jenkins/workspace/tic-agent_elastic-agent-mbp_main/src/github.com/elastic/elastic-agent:/go/src/github.com/elastic/elastic-agent -w /go/src/github.com/elastic/elastic-agent docker.elastic.co/beats-dev/golang-crossbuild:1.19.8-arm --build-cmd build/mage-linux-arm64 golangCrossBuild --platforms linux/arm64" failed with exit code 125

Should we temporarily revert this PR merge, until elastic/golang-crossbuild#282 is merged first?

[cmacknz]

Ugh, yes we should revert this.

We also need to look into why the build "succeeded" without any use of the cross build image #2475 (comment)

[cmacknz]

#2515

[ycombinator]

Comparing the "successful" build from this PR (https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2512/1/pipeline/909) and the failing build on main (https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/main/908/pipeline/822), we can see that the packaging error happens in the failing build when mage package ironbank is called. For whatever reason, in the "successful" build, the Package stage never gets around to calling mage package ironbank.

I randomly sampled some other "successful" PR builds, viz:

• https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2348/10/pipeline/884
• https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2352/14/pipeline/884
• https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2468/10/pipeline/822
• https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2472/3/pipeline/884
• https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2505/3/pipeline/822

In every case the Package stage never gets around to calling mage package (I think the ironbank target is irrelevant to this situation). Instead, the Package stage just has a couple of these log entries for it:

[2023-04-11T11:33:24.083Z] [INFO] githubApiCall: just been called.

So we need to figure out what's different in the Package stage's configuration between PR builds and main builds and why.

[ycombinator]

So we need to figure out what's different in the Package stage's configuration between PR builds and main builds and why.

I'm not too familiar with the Jenkins CI config DSL but I think this is why the Package stage might not be running on PR builds:

elastic-agent/.ci/Jenkinsfile

Line 173 in 732ad1f

not { changeRequest() }

I'll put up a test PR with that line removed and see if it makes the Package stage run.

[ycombinator]

I'm not too familiar with the Jenkins CI config DSL but I think this is why the Package stage might not be running on PR builds:

elastic-agent/.ci/Jenkinsfile

Line 173 in 732ad1f

not { changeRequest() }

I'll put up a test PR with that line removed and see if it makes the Package stage run.

Test PR is up: #2516. And it looks like CI is running the Package stage on that PR and, as of this writing, failing as would be expected: https://fleet-ci.elastic.co/blue/organizations/jenkins/elastic-agent%2Felastic-agent-mbp/detail/PR-2516/1/pipeline/656.