Skip to content

[9.0] (backport #10004) Fix flaky integration tests for the monitoring endpoint#10017

Merged
swiatekm merged 1 commit into9.0from
mergify/bp/9.0/pr-10004
Sep 18, 2025
Merged

[9.0] (backport #10004) Fix flaky integration tests for the monitoring endpoint#10017
swiatekm merged 1 commit into9.0from
mergify/bp/9.0/pr-10004

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Sep 18, 2025

What does this PR do?

Improves the reliability of the monitoring reload tests and fixes an issue with the fipsonly tests related to testify assertion use. These failures originally surfaced in #9952, and I've also noticed it in #9903, but the fixes are generally applicable, so I'm applying them to all branches.

Why is it important?

Tests should be reliable.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in ./changelog/fragments using the changelog tool
  • [ ] I have added an integration test or an E2E test

This is an automatic backport of pull request #10004 done by [Mergify](https://mergify.com).

@mergify mergify Bot requested a review from a team as a code owner September 18, 2025 02:31
@mergify mergify Bot added the backport label Sep 18, 2025
@mergify mergify Bot requested review from pchila and rubenruizdegauna and removed request for a team September 18, 2025 02:31
@github-actions github-actions Bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team flaky-test Unstable or unreliable test cases. skip-changelog labels Sep 18, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Sep 18, 2025

💔 Build Failed

Failed CI Steps

History

cc @swiatekm

* Fix monitoring reloading tests

Ensure we verify the policy update was actually applied before querying
the monitoring endpoint. Add a retry on said request as well.

* Use the explicit policy revision returned by Kibana

(cherry picked from commit 5372f24)
@swiatekm swiatekm force-pushed the mergify/bp/9.0/pr-10004 branch from 0f086e7 to 521629f Compare September 18, 2025 10:12
@swiatekm swiatekm enabled auto-merge (squash) September 18, 2025 10:12
@elastic-sonarqube
Copy link
Copy Markdown

@swiatekm swiatekm merged commit 6217a92 into 9.0 Sep 18, 2025
23 checks passed
@swiatekm swiatekm deleted the mergify/bp/9.0/pr-10004 branch September 18, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport flaky-test Unstable or unreliable test cases. skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants