Fix flaky integration tests for the monitoring endpoint#10004
Merged
Conversation
swiatekm
added
the
Team:Elastic-Agent-Control-Plane
swiatekm
added
flaky-test
Contributor
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
swiatekm
changed the title
cmacknz
previously approved these changes
Sep 17, 2025
Member
cmacknz
left a comment
cmacknz
left a comment
There was a problem hiding this comment.
Thank you! Addresses what was found in #9952 (comment)
We may find we need to relax newPolicyRevision := agent.PolicyRevision + 1 to just that the new revision is greater than the old one because we don't care about the specific revision. Regardless having the revision increment by one should be what happens, we just might be exposed to bugs in Fleet where it generates unnecessary revisions or some other update (from another test that isn't as isolated as it should be) causes an extra revision.
cmacknz
reviewed
Sep 17, 2025
cmacknz
previously approved these changes
Sep 17, 2025
ycombinator
force-pushed
the
test/fix-failing-tests
branch
from
1c51244 to
2f5b10c
Compare
Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well.
ycombinator
force-pushed
the
test/fix-failing-tests
branch
from
2f5b10c to
f6a2d5c
Compare
|
cmacknz
approved these changes
Sep 18, 2025
Member
|
Force merging, the actual tests changed here have passed multiple times and now we are waiting for Kubernetes tests. |
Contributor
|
@Mergifyio backport 8.18 8.19 9.0 9.1 |
Contributor
✅ Backports have been createdDetails
|
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
This was referenced Sep 18, 2025
mergify Bot
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
3 tasks
cmacknz
pushed a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana
Contributor
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24)
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
) * Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
) * Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
) * Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
swiatekm
added a commit
that referenced
this pull request
Sep 18, 2025
) * Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana (cherry picked from commit 5372f24) Co-authored-by: Mikołaj Świątek <mail@mikolajswiatek.com>
intxgo
pushed a commit
to intxgo/elastic-agent
that referenced
this pull request
Sep 24, 2025
* Fix monitoring reloading tests Ensure we verify the policy update was actually applied before querying the monitoring endpoint. Add a retry on said request as well. * Use the explicit policy revision returned by Kibana
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Improves the reliability of the monitoring reload tests and fixes an issue with the fipsonly tests related to testify assertion use. These failures originally surfaced in #9952, and I've also noticed it in #9903, but the fixes are generally applicable, so I'm applying them to all branches.
Why is it important?
Tests should be reliable.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry in./changelog/fragmentsusing the changelog tool[ ] I have added an integration test or an E2E test