Add missing hash fields to process.parent: attempt 2#739
Merged
webmat merged 5 commits intoelastic:masterfrom Feb 4, 2020
Merged
Add missing hash fields to process.parent: attempt 2#739webmat merged 5 commits intoelastic:masterfrom
webmat merged 5 commits intoelastic:masterfrom
Conversation
webmat
approved these changes
Feb 4, 2020
Contributor
webmat
left a comment
webmat
left a comment
There was a problem hiding this comment.
LGTM! Thanks Marshall :-)
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Mar 4, 2020
- code_signature (elastic#733) - second entry for elastic#739 in the schema section, mentioning the addition of `process.parent.hash` Also adjusted the wording of elastic#731 and elastic#747.
dcode
pushed a commit
to dcode/ecs
that referenced
this pull request
Apr 15, 2020
This issue also adds flexibility to the reuse mechanism, in allowing us to nest at a nested destination
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same idea as #698 redone to integrate with intermediate data format changes.
Recently process.parent fields that are identical to the process fields were added to ECS, but the hash fields that are nested under "process" did not get added to process.parent. This PR adds "process.parent" to the list of nestings in "hash" and also support for nesting fields at levels other than the top level of the destination schema using the '.' notation (e.g. process.parent). Previously nested fields could only be inserted at the top level.