Skip to content

Add missing hash fields to process.parent#698

Closed
marshallmain wants to merge 1 commit intoelastic:masterfrom
marshallmain:add-parent-hash
Closed

Add missing hash fields to process.parent#698
marshallmain wants to merge 1 commit intoelastic:masterfrom
marshallmain:add-parent-hash

Conversation

@marshallmain
Copy link
Copy Markdown
Contributor

Recently process.parent fields that are identical to the process fields were added to ECS, but the hash fields that are nested under "process" did not get added to process.parent. This PR adds "process.parent" to the list of nestings in "hash" and also support for nesting fields at levels other than the top level of the destination schema using the '.' notation (e.g. process.parent). Previously nested fields could only be inserted at the top level.

@webmat
Copy link
Copy Markdown
Contributor

webmat commented Dec 18, 2019

Huge thanks for submitting this @marshallmain 💯

Copy link
Copy Markdown
Contributor

@webmat webmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once merged/rebased

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants