Skip to content

Backport #640 to 1.2: Flesh out the csv a little#650

Closed
webmat wants to merge 1 commit intoelastic:1.2from
webmat:backport_640_1.2
Closed

Backport #640 to 1.2: Flesh out the csv a little#650
webmat wants to merge 1 commit intoelastic:1.2from
webmat:backport_640_1.2

Conversation

@webmat
Copy link
Copy Markdown
Contributor

@webmat webmat commented Nov 26, 2019

Backport of PR #640 to 1.2 branch. Original message:

In this PR:

  • Add the field set column
  • Add the short description
  • Add whether the field should be indexed
  • Reorder the columns a bit, so the stable length values are first

Preview GitHub's rendering of generated/csv/fields.csv (scroll right for definitions)

@webmat webmat self-assigned this Nov 26, 2019
@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Nov 26, 2019

@ruflin Unsure what to do about messaging this backport. I wouldn't rev the ECS version, as the schema hasn't changed, only the csv file has.

Also, in 1.3 we're introducing the separation in the changelog for schema changes vs tooling/artifact changes. For 1.2.0 and before, we rarely messaged anything about tooling/artifact changes, so the changelog entries no longer have a home in older versions. I see two paths forward:

  1. Just backport without any changelog entry, consistent with earlier versions' use of the changelog.
  2. Retroactively introduce the changelog separation for all past releases, and reintroduce the changelog entries there.

I would tend to favor option 1, for simplicity's sake. WDYT?

@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Nov 27, 2019

Why would you backport this in the first place?

@webmat
Copy link
Copy Markdown
Contributor Author

webmat commented Nov 27, 2019

To have the same format available for all versions.

Do you see a problem with this?

@webmat webmat closed this Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants