Backport #640 to 1.2: Flesh out the csv a little#650
Closed
webmat wants to merge 1 commit intoelastic:1.2from
Closed
Backport #640 to 1.2: Flesh out the csv a little#650webmat wants to merge 1 commit intoelastic:1.2from
webmat wants to merge 1 commit intoelastic:1.2from
Conversation
Contributor
Author
|
@ruflin Unsure what to do about messaging this backport. I wouldn't rev the ECS version, as the schema hasn't changed, only the csv file has. Also, in 1.3 we're introducing the separation in the changelog for schema changes vs tooling/artifact changes. For 1.2.0 and before, we rarely messaged anything about tooling/artifact changes, so the changelog entries no longer have a home in older versions. I see two paths forward:
I would tend to favor option 1, for simplicity's sake. WDYT? |
This was referenced Nov 26, 2019
Contributor
|
Why would you backport this in the first place? |
Contributor
Author
|
To have the same format available for all versions. Do you see a problem with this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #640 to 1.2 branch. Original message:
In this PR:
Preview GitHub's rendering of generated/csv/fields.csv (scroll right for definitions)