Backport #621 to 1.3: Flesh out the csv a little#640
Merged
webmat merged 2 commits intoelastic:1.3from Nov 26, 2019
Merged
Conversation
added 2 commits
November 26, 2019 09:01
This ensures it's easy to have the column as a boolean in Elasticsearch
ruflin
approved these changes
Nov 26, 2019
Contributor
ruflin
left a comment
ruflin
left a comment
There was a problem hiding this comment.
LGTM
I would prefer to have 1 backport per PR in the future. Like this I can just look at the PR and not have to check commits, and I know the merging is not going to be squashing by accident ;-)
Contributor
Author
|
Yeah I agree. In this case though I want to backport this new csv format all the way back, though (after the release). This single PR will make further backports a little easier. |
webmat
changed the title
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Nov 26, 2019
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Nov 26, 2019
webmat
pushed a commit
to webmat/ecs
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #621 and #638 to 1.3 branch. Original message:
In this PR:
Preview GitHub's rendering of generated/csv/fields.csv (scroll right for definitions)