Skip to content

[docs] Fix image paths for docs-assembler#2464

Merged
mjwolf merged 2 commits into
elastic:mainfrom
colleenmcginnis:fix-images-when-assembled
Apr 22, 2025
Merged

[docs] Fix image paths for docs-assembler#2464
mjwolf merged 2 commits into
elastic:mainfrom
colleenmcginnis:fix-images-when-assembled

Conversation

@colleenmcginnis
Copy link
Copy Markdown
Contributor

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.
  • Can you please add the appropriate labels needed for backporting?

@colleenmcginnis colleenmcginnis added documentation DOCS Any issue related to ECS documentation labels Apr 15, 2025
@colleenmcginnis colleenmcginnis self-assigned this Apr 15, 2025
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner April 15, 2025 23:10
@github-actions
Copy link
Copy Markdown
Contributor

Documentation changes preview: https://ecs_bk_2464.docs-preview.app.elstc.co/diff

@colleenmcginnis colleenmcginnis requested a review from mjwolf April 17, 2025 12:52
@mjwolf mjwolf merged commit 7f96128 into elastic:main Apr 22, 2025
3 of 4 checks passed
mjwolf added a commit to mjwolf/ecs that referenced this pull request Apr 22, 2025
Co-authored-by: Michael Wolf <michael.wolf@elastic.co>
mjwolf added a commit to mjwolf/ecs that referenced this pull request Apr 22, 2025
Co-authored-by: Michael Wolf <michael.wolf@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DOCS Any issue related to ECS documentation documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants