-
Notifications
You must be signed in to change notification settings - Fork 346
Modify attribute for Ingest Guide #2580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Some details and decisions to be addressed: |
|
Looks like most of the offending references are for 7.8 and 7.9. If we fix those, then we should be able to repurpose the attribute without too much upheaval. The |
|
@dedemorton, here's the PR where you made the original change. Now that our Ingest vision is becoming more clear, let's consider resetting Please let me know what you think. I don't want to plow ahead without input from you. |
|
@karenzone I think that's a good idea. The original attribute was left over from when we were calling the UI ingest management rather than Fleet. :-) I'm starting to feel a bit of whiplash, TBH, but let's go with the change! Let me know how I can help. |
|
I'll get those broken links fixed up this week. |
|
@elasticmachine run elasticsearch-ci/docs rebuild |
dedemorton
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. PR just needs to be marked as ready for review :-)
The
:ingest-guide:attribute is set to resolve tohttps://www.elastic.co/guide/en/fleet/{branch}. This PR updates the attribute.Is the
:ingest-guide:attribute currently in use anywhere? Docs-ci will tell us... but we might have to wait until after #2578 is merged.UPDATE: Yes! The attribute is in use for some 7.x branches. See comments.
DO NOT MERGE until after #2578 has been merged.