Skip to content

Conversation

@dedemorton
Copy link
Contributor

Fixes attribute that uses old path for Fleet docs. I should have changed this when we changed the path to all versions of the book.

After this PR is merged, we should be able to remove all the old files under https://github.com/elastic/built-docs/tree/master/html/en/ingest-management

@dedemorton dedemorton requested a review from gtback October 21, 2021 19:07
@dedemorton dedemorton self-assigned this Oct 21, 2021
@dedemorton
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@dedemorton
Copy link
Contributor Author

Trying another build because I don't see any reason why the Elasticsearch Guide isn't picking up the changed path.

@gtback
Copy link
Member

gtback commented Oct 21, 2021

19:30:43 INFO:build_docs:Bad cross-document links:
19:30:43 INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/reference/7.10/breaking-changes-7.9.html contains broken links to:
19:30:43 INFO:build_docs:   - en/fleet/7.10/ingest-management-overview.html

@dedemorton This page: https://www.elastic.co/guide/en/elasticsearch/reference/7.10/breaking-changes-7.9.html contains a link to the 7.10 "Elastic Agent" (ingest-management) guide: https://www.elastic.co/guide/en/ingest-management/7.10/ingest-management-overview.html.

It's possible that a full rebuild might fix this, or we might need to update that in the old Elasticsearch docs.

Copy link
Member

@gtback gtback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the Elasticsearch changes in elastic/elasticsearch#79660 (and backports) land.

@jrodewig
Copy link
Contributor

elastic/elasticsearch#79660 is merged and backported. Rerunning the docs build.

@elasticmachine run elasticsearch-ci/docs

@dedemorton dedemorton merged commit 54335b0 into elastic:master Oct 21, 2021
@dedemorton dedemorton deleted the update_old_links branch October 21, 2021 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants